fix: XTC 1-bit thumb BMP polarity inversion#373
Merged
daveallie merged 1 commit intocrosspoint-reader:masterfrom Jan 19, 2026
Merged
fix: XTC 1-bit thumb BMP polarity inversion#373daveallie merged 1 commit intocrosspoint-reader:masterfrom
daveallie merged 1 commit intocrosspoint-reader:masterfrom
Conversation
daveallie
approved these changes
Jan 14, 2026
daveallie
changed the title
The thumb BMP generation for 1-bit XTC files had inverted polarity, causing the Continue Reading cover image to appear with inverted colors. - Fix: Change `grayValue = pixelBit ? 0 : 255` to `grayValue = pixelBit ? 255 : 0` to match the cover BMP generation logic where bit=0 is black and bit=1 is white - Update misleading comment about XTC polarity
auto-merge was automatically disabled
January 14, 2026 15:55
Head branch was pushed to by a user without write access
eunchurn
force-pushed
the
fix/xtc-thumb-polarity
branch
from
c9a8fe9 to
4cb9158
Compare
daveallie
approved these changes
Jan 19, 2026
jdk2pq
added a commit
to jdk2pq/crosspoint-reader
that referenced
this pull request
Jan 20, 2026
* origin: fix: truncate chapter names that are too long (crosspoint-reader#422) feat: dict based Hyphenation (crosspoint-reader#305) fix: render U+FFFD replacement character instead of ? (crosspoint-reader#366) fix: Invert colors on home screen cover overlay when recent book is selected (crosspoint-reader#390) Adds KOReader Sync support (crosspoint-reader#232) feat: Change keyboard "caps" to "shift" & Wrap Keyboard (crosspoint-reader#377) fix: XTC 1-bit thumb BMP polarity inversion (crosspoint-reader#373)
yingirene
pushed a commit
to yingirene/crosspoint-reader
that referenced
this pull request
Jan 25, 2026
## Summary * **What is the goal of this PR?** (e.g., Implements the new feature for file uploading.) * **What changes are included?** - Fix inverted colors in Continue Reading cover image for 1-bit XTC files ## Additional Context * Add any other information that might be helpful for the reviewer (e.g., performance implications, potential risks, specific areas to focus on). - Fix `grayValue = pixelBit ? 0 : 255` → `grayValue = pixelBit ? 255 : 0` in `lib/Xtc/Xtc.cpp` - The thumb BMP generation had inverted polarity compared to cover BMP generation - bit=0 should be black, bit=1 should be white (matching the BMP palette order) - Update misleading comment about XTC polarity --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**PARTIALLY**_
Unintendedsideeffects
pushed a commit
to Unintendedsideeffects/crosspoint-reader
that referenced
this pull request
Feb 17, 2026
## Summary * **What is the goal of this PR?** (e.g., Implements the new feature for file uploading.) * **What changes are included?** - Fix inverted colors in Continue Reading cover image for 1-bit XTC files ## Additional Context * Add any other information that might be helpful for the reviewer (e.g., performance implications, potential risks, specific areas to focus on). - Fix `grayValue = pixelBit ? 0 : 255` → `grayValue = pixelBit ? 255 : 0` in `lib/Xtc/Xtc.cpp` - The thumb BMP generation had inverted polarity compared to cover BMP generation - bit=0 should be black, bit=1 should be white (matching the BMP palette order) - Update misleading comment about XTC polarity --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**PARTIALLY**_
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Additional Context
specific areas to focus on).
grayValue = pixelBit ? 0 : 255→grayValue = pixelBit ? 255 : 0inlib/Xtc/Xtc.cppAI Usage
While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it
helps set the right context for reviewers.
Did you use AI tools to help write this code? PARTIALLY