Skip to content

Reclaim space if we don't show battery Percentage#352

Merged
daveallie merged 3 commits intocrosspoint-reader:masterfrom
jonasdiemer:improve/chapter-vs-battery-placement
Jan 21, 2026
Merged

Reclaim space if we don't show battery Percentage#352
daveallie merged 3 commits intocrosspoint-reader:masterfrom
jonasdiemer:improve/chapter-vs-battery-placement

Conversation

@jonasdiemer
Copy link
Contributor

Summary

Give space to the chapter title if we don't show battery percentage.


AI Usage

While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it
helps set the right context for reviewers.

Did you use AI tools to help write this code? NO

@pablohc
Copy link
Contributor

pablohc commented Jan 13, 2026

Hi @jonasdiemer related to chapter title, I opened this issue #354

Is it possible to align it with respect to the center of the screen?

@jonasdiemer
Copy link
Contributor Author

It's possible to center, but then we give up space in case left and right "clutter" (battery + progress) are using up different amounts of space.

daveallie
daveallie previously approved these changes Jan 14, 2026
@daveallie
Copy link
Member

There's likely a middle ground here, calculating the max width we can display the text while centered. If it's less than that, then render it in the center, otherwise use the existing centering logic. Would just require knowing the max of left and right title margins.

Thoughts @jonasdiemer?

daveallie
daveallie previously approved these changes Jan 21, 2026
Copy link
Member

@daveallie daveallie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjusted the logic to support #352 (comment)

@daveallie daveallie enabled auto-merge (squash) January 21, 2026 12:04
@daveallie daveallie merged commit 87d6c03 into crosspoint-reader:master Jan 21, 2026
1 check passed
jdk2pq added a commit to jdk2pq/crosspoint-reader that referenced this pull request Jan 23, 2026
* master:
  chore: Cut release 0.15.0
  fix: OPDS browser OOM (crosspoint-reader#403)
  docs: Add detailed webserver documentation (crosspoint-reader#446)
  feat: invalidate cache on web uploads and opds downloads and add Clear Cache action (crosspoint-reader#393)
  fix: hard reset via RTS pin after flashing firmware (crosspoint-reader#437)
  fix: Skip negative screen coordinates only after we read the bitmap row. (crosspoint-reader#431)
  Reclaim space if we don't show battery Percentage (crosspoint-reader#352)
  feat: Include superscripts and subscripts in fonts (crosspoint-reader#463)
  My Library: Tab bar w/ Recent Books + File Browser (crosspoint-reader#250)
  feat: adding categories to settings screen (crosspoint-reader#331)
yingirene pushed a commit to yingirene/crosspoint-reader that referenced this pull request Jan 25, 2026
)

## Summary

Give space to the chapter title if we don't show battery percentage.

---

### AI Usage

While CrossPoint doesn't have restrictions on AI tools in contributing,
please be transparent about their usage as it
helps set the right context for reviewers.

Did you use AI tools to help write this code? _**NO**_

---------

Co-authored-by: Dave Allie <[email protected]>
Unintendedsideeffects pushed a commit to Unintendedsideeffects/crosspoint-reader that referenced this pull request Feb 17, 2026
)

## Summary

Give space to the chapter title if we don't show battery percentage.

---

### AI Usage

While CrossPoint doesn't have restrictions on AI tools in contributing,
please be transparent about their usage as it
helps set the right context for reviewers.

Did you use AI tools to help write this code? _**NO**_

---------

Co-authored-by: Dave Allie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants