Skip to content

Feature: Extend Cover image#351

Draft
jonasdiemer wants to merge 7 commits intocrosspoint-reader:masterfrom
jonasdiemer:feature/extend-image
Draft

Feature: Extend Cover image#351
jonasdiemer wants to merge 7 commits intocrosspoint-reader:masterfrom
jonasdiemer:feature/extend-image

Conversation

@jonasdiemer
Copy link
Contributor

Summary

This feature adds an option "extend" to the Cover mode, which takes 20 pixels from the corners of the cover image and repeats them outwards in accordeon style. This avoids cropping and still fills the whole screen. Works best when the image "almost" fits.


AI Usage

While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it
helps set the right context for reviewers.

Did you use AI tools to help write this code? ** PARTIALLY**

@pablohc
Copy link
Contributor

pablohc commented Jan 13, 2026

Hi @jonasdiemer related to the sleep screen, I opened this issue: #348.
Is there any difference in image processing depending on the image adjust mode?

@daveallie
Copy link
Member

Obviously every book cover is different, but the usable covers for this kind of upscaling is extremely small, as an example:

Fit/Crop Extend
IMG_5813 IMG_5812

If we plan to upscale to fit/crop then we should actually be upscaling instead of repeating parts of the image. Even a very basic repeat every nth pixel, like how we downscale by skipping every nth pixel would be good.

@jonasdiemer
Copy link
Contributor Author

Obviously every book cover is different, but the usable covers for this kind of upscaling is extremely small, ...
If we plan to upscale to fit/crop then we should actually be upscaling instead of repeating parts of the image. Even a very basic repeat every nth pixel, like how we downscale by skipping every nth pixel would be good.

I fully agree, we'd need separate upscaling for when the image is too small in both directions.

I found the extension working very well when the cover is slightly too large/small in one dimension as a good alternative to cropping (which has the risk of removing content) or fitting (which leaves blank space)...

Eg here, "fit" leaves space:
IMG_1737

whereas expand works nicely (agreed, in this example crop would have worked, too):

IMG_1738

@daveallie
Copy link
Member

Before this is merged I'd love to solve the case raised here: #351 (comment)

It might just as simple as always upscaling to at least the screen size (based on fit/fill), and then applying extend after that upscale.

@jonasdiemer
Copy link
Contributor Author

Before this is merged I'd love to solve the case raised here: #351 (comment)

It might just as simple as always upscaling to at least the screen size (based on fit/fill), and then applying extend after that upscale.

Yes, we should probably always upscale. If anyone wants to take a stab at this, don't wait for me 😉

daveallie pushed a commit that referenced this pull request Jan 27, 2026
Supersedes #358 and includes the bugfix from #351
@daveallie
Copy link
Member

Moving this back into draft (mostly for reviewer benefit when scanning open PRs), won't be merged without addressing comments

@daveallie daveallie marked this pull request as draft January 27, 2026 12:18
Jessica765 pushed a commit to Jessica765/crosspoint-reader that referenced this pull request Feb 3, 2026
Unintendedsideeffects pushed a commit to Unintendedsideeffects/crosspoint-reader that referenced this pull request Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants