feat: Add settings editing to web UI#346
Closed
itsthisjustin wants to merge 1 commit intocrosspoint-reader:masterfrom
Closed
feat: Add settings editing to web UI#346itsthisjustin wants to merge 1 commit intocrosspoint-reader:masterfrom
itsthisjustin wants to merge 1 commit intocrosspoint-reader:masterfrom
Conversation
Add a new Settings page to the crosspoint.local web interface that allows viewing and editing all device settings via the hotspot. Settings page that auto-generates form from settings metadata New settings added to SettingsList.h automatically appear in both the device UI and web UI - Supports all setting types: toggle, enum, value (range), and string - Settings are saved immediately and persist to SD card API endpoints: - GET /settings - Settings page - GET /api/settings - Returns all settings with metadata as JSON - POST /api/settings - Updates settings (accepts JSON key-value pairs)
Contributor
Author
|
@daveallie Added the hotspot settings feature here if you're interested |
|
Works great - saved me a lot of time testing Calibre-web stuff |
Contributor
Author
Exactly haha |
daveallie
requested changes
Jan 14, 2026
Member
daveallie
left a comment
daveallie
left a comment
There was a problem hiding this comment.
This is great, any keyboard entry on the device is a real pain. Just some feedback around settings appearing twice.
Comment on lines
+42
to
+43
| SettingInfo::String("opdsServerUrl", "Calibre Web URL", SETTINGS.opdsServerUrl, | ||
| sizeof(SETTINGS.opdsServerUrl) - 1), |
Member
There was a problem hiding this comment.
This setting now appears in the UI for the root settings options, but also in the Calibre Settings sub-section. Perhaps we should categories all settings (just leaving all the existing ones as "General" which show up at the root settings page), and then the UI in the web/on-device could be a little more capable of supporting these subsections. <- This isn't my greatest idea, and if you'd prefer to defer this issue for the moment by just marking settings as "hidden" in this list for the device UI, then I'm ok with that, or if you have better ideas, happy to take a look at another approach
|
This would be awesome! Im currently trying to setup OPDS and KoReader and its a pain |
obra
pushed a commit
to obra/crosspoint-reader
that referenced
this pull request
Feb 2, 2026
Reimplements PR crosspoint-reader#346 on top of current master. Adds a web settings page at /settings that allows viewing and editing all device settings via the hotspot, with GET/POST JSON API at /api/settings.
Contributor
Author
|
closing this pr in favor of one from @obra |
daveallie
added a commit
that referenced
this pull request
Feb 8, 2026
## Summary This is an updated version of @itsthisjustin's #346 that builds on current master and also deduplicates the settings list so we don't have two copies of the settings. In the Web UI, it should organize the settings a little closer to what you see on device. ## Additional Context I tested this live on device and it seems to play nicely for me. It's re-based on master since master's settings stuff has moved somewhat since the original PR and addresses the sole review comment #346 - it also means that I don't need to manually key in the URL for my OPDS server. :) --- ### AI Usage My changes were implemented with Claude Opus 4.5 and Claude Code 2.1.25. I don't know if @itsthisjustin's original work used AI assistance. Co-authored-by: Dave Allie <[email protected]>
lukestein
pushed a commit
to lukestein/crosspoint-reader
that referenced
this pull request
Feb 8, 2026
## Summary This is an updated version of @itsthisjustin's crosspoint-reader#346 that builds on current master and also deduplicates the settings list so we don't have two copies of the settings. In the Web UI, it should organize the settings a little closer to what you see on device. ## Additional Context I tested this live on device and it seems to play nicely for me. It's re-based on master since master's settings stuff has moved somewhat since the original PR and addresses the sole review comment crosspoint-reader#346 - it also means that I don't need to manually key in the URL for my OPDS server. :) --- ### AI Usage My changes were implemented with Claude Opus 4.5 and Claude Code 2.1.25. I don't know if @itsthisjustin's original work used AI assistance. Co-authored-by: Dave Allie <[email protected]>
lukestein
pushed a commit
to lukestein/crosspoint-reader
that referenced
this pull request
Feb 8, 2026
## Summary This is an updated version of @itsthisjustin's crosspoint-reader#346 that builds on current master and also deduplicates the settings list so we don't have two copies of the settings. In the Web UI, it should organize the settings a little closer to what you see on device. ## Additional Context I tested this live on device and it seems to play nicely for me. It's re-based on master since master's settings stuff has moved somewhat since the original PR and addresses the sole review comment crosspoint-reader#346 - it also means that I don't need to manually key in the URL for my OPDS server. :) --- ### AI Usage My changes were implemented with Claude Opus 4.5 and Claude Code 2.1.25. I don't know if @itsthisjustin's original work used AI assistance. Co-authored-by: Dave Allie <[email protected]>
lukestein
pushed a commit
to lukestein/crosspoint-reader
that referenced
this pull request
Feb 8, 2026
## Summary This is an updated version of @itsthisjustin's crosspoint-reader#346 that builds on current master and also deduplicates the settings list so we don't have two copies of the settings. In the Web UI, it should organize the settings a little closer to what you see on device. ## Additional Context I tested this live on device and it seems to play nicely for me. It's re-based on master since master's settings stuff has moved somewhat since the original PR and addresses the sole review comment crosspoint-reader#346 - it also means that I don't need to manually key in the URL for my OPDS server. :) --- ### AI Usage My changes were implemented with Claude Opus 4.5 and Claude Code 2.1.25. I don't know if @itsthisjustin's original work used AI assistance. Co-authored-by: Dave Allie <[email protected]>
Unintendedsideeffects
pushed a commit
to Unintendedsideeffects/crosspoint-reader
that referenced
this pull request
Feb 17, 2026
## Summary This is an updated version of @itsthisjustin's crosspoint-reader#346 that builds on current master and also deduplicates the settings list so we don't have two copies of the settings. In the Web UI, it should organize the settings a little closer to what you see on device. ## Additional Context I tested this live on device and it seems to play nicely for me. It's re-based on master since master's settings stuff has moved somewhat since the original PR and addresses the sole review comment crosspoint-reader#346 - it also means that I don't need to manually key in the URL for my OPDS server. :) --- ### AI Usage My changes were implemented with Claude Opus 4.5 and Claude Code 2.1.25. I don't know if @itsthisjustin's original work used AI assistance. Co-authored-by: Dave Allie <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new Settings page to the crosspoint.local web interface that allows viewing and editing all device settings via the hotspot.
Settings page that auto-generates form from settings metadata New settings added to SettingsList.h automatically
appear in both the device UI and web UI
API endpoints: