feat: adding categories to settings screen#331
Merged
daveallie merged 3 commits intocrosspoint-reader:masterfrom Jan 21, 2026
Merged
feat: adding categories to settings screen#331daveallie merged 3 commits intocrosspoint-reader:masterfrom
daveallie merged 3 commits intocrosspoint-reader:masterfrom
Conversation
Contributor
Author
|
This would cause all MRs that change settings to pull this in, including my own. This does feel like the correct trade off. But will also keep this up to date with master on every merge. |
Contributor
Author
|
@daveallie does it make sense to keep this up to date with master? Or should I just wait for a review first. |
daveallie
previously approved these changes
Jan 21, 2026
Member
daveallie
left a comment
daveallie
left a comment
There was a problem hiding this comment.
Looks great, I'll merge in master and get it merged now to avoid further conflicts.
daveallie
approved these changes
Jan 21, 2026
jdk2pq
added a commit
to jdk2pq/crosspoint-reader
that referenced
this pull request
Jan 23, 2026
* master: chore: Cut release 0.15.0 fix: OPDS browser OOM (crosspoint-reader#403) docs: Add detailed webserver documentation (crosspoint-reader#446) feat: invalidate cache on web uploads and opds downloads and add Clear Cache action (crosspoint-reader#393) fix: hard reset via RTS pin after flashing firmware (crosspoint-reader#437) fix: Skip negative screen coordinates only after we read the bitmap row. (crosspoint-reader#431) Reclaim space if we don't show battery Percentage (crosspoint-reader#352) feat: Include superscripts and subscripts in fonts (crosspoint-reader#463) My Library: Tab bar w/ Recent Books + File Browser (crosspoint-reader#250) feat: adding categories to settings screen (crosspoint-reader#331)
yingirene
pushed a commit
to yingirene/crosspoint-reader
that referenced
this pull request
Jan 25, 2026
## Summary * **What is the goal of this PR?** (e.g., Fixes a bug in the user authentication module, Implements the new feature for file uploading.) As we get more settings, I think it makes sense to do categories for them. This just allows users to find the settings easier and navigate to them. * **What changes are included?** ## Additional Context * Add any other information that might be helpful for the reviewer (e.g., performance implications, potential risks, specific areas to focus on). Co-authored-by: dpoulter <[email protected]> Co-authored-by: Dave Allie <[email protected]>
Unintendedsideeffects
pushed a commit
to Unintendedsideeffects/crosspoint-reader
that referenced
this pull request
Feb 17, 2026
## Summary * **What is the goal of this PR?** (e.g., Fixes a bug in the user authentication module, Implements the new feature for file uploading.) As we get more settings, I think it makes sense to do categories for them. This just allows users to find the settings easier and navigate to them. * **What changes are included?** ## Additional Context * Add any other information that might be helpful for the reviewer (e.g., performance implications, potential risks, specific areas to focus on). Co-authored-by: dpoulter <[email protected]> Co-authored-by: Dave Allie <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
file uploading.)
As we get more settings, I think it makes sense to do categories for them. This just allows users to find the settings easier and navigate to them.
Additional Context