Support up to 500 character file names#275
Merged
Conversation
438856e to
c986641
Compare
Contributor
|
With escaping for special characters can these exceed 512 bytes for |
Member
Author
|
Could you explain more about this issue @swwilshub? "Character" probably want's the right word to use in the title, it should really be "byte", we're allocating a 500 byte array for the title and then calling /**
* Get a file's name followed by a zero byte.
*
* \param[out] name An array of characters for the file's name.
* \param[in] len The size of the array in bytes. The array
* must be at least 13 bytes long. The file's name will be
* truncated if the file's name is too long.
* \return The length of the returned string.
*/So for files with names longer than 500 bytes, we'd just get a truncated name as before. These changes don't fully solve the issue, but extending it to 500 bytes seems like an acceptable limit to me atm. |
yingirene
pushed a commit
to yingirene/crosspoint-reader
that referenced
this pull request
Jan 16, 2026
## Summary - Support up to 500 character file names ## Additional Context - Fixes crosspoint-reader#265
Unintendedsideeffects
pushed a commit
to Unintendedsideeffects/crosspoint-reader
that referenced
this pull request
Feb 17, 2026
## Summary - Support up to 500 character file names ## Additional Context - Fixes crosspoint-reader#265
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Additional Context