Add superscripts/subscripts to fonts and add Nix devshell#248
Closed
cor wants to merge 5 commits intocrosspoint-reader:masterfrom
Closed
Add superscripts/subscripts to fonts and add Nix devshell#248cor wants to merge 5 commits intocrosspoint-reader:masterfrom
cor wants to merge 5 commits intocrosspoint-reader:masterfrom
Conversation
cor
force-pushed
the
subscript-superscript
branch
from
ef9de34 to
cfb52c5
Compare
daveallie
requested changes
Jan 7, 2026
Member
daveallie
left a comment
daveallie
left a comment
There was a problem hiding this comment.
Can you please update the fontIds.h file with the new font IDs.
Also, I'm not really across the concept of a nix devshell and in the interest of not maintaining something I don't understand, I don't really want it to be added to the project, would you mind removing it from the diff
|
Most of my books contain superscripts, is it possible to know, when this futere will be added to Crosspoint? I'm not a Guthub guy, so if this not a place for such a comment please forgive me and delete it : )) |
Member
|
Cherry-picked the relevant commit into #463, and updated the fonts there. Will close this one out as the only other thing in it is the Nix devshell which I don't want to merge. |
daveallie
added a commit
that referenced
this pull request
Jan 21, 2026
## Summary * Include superscripts and subscripts in fonts ## Additional Context * Original change came from #248 --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? No --------- Co-authored-by: cor <[email protected]>
yingirene
pushed a commit
to yingirene/crosspoint-reader
that referenced
this pull request
Jan 25, 2026
…#463) ## Summary * Include superscripts and subscripts in fonts ## Additional Context * Original change came from crosspoint-reader#248 --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? No --------- Co-authored-by: cor <[email protected]>
Unintendedsideeffects
pushed a commit
to Unintendedsideeffects/crosspoint-reader
that referenced
this pull request
Feb 17, 2026
…#463) ## Summary * Include superscripts and subscripts in fonts ## Additional Context * Original change came from crosspoint-reader#248 --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? No --------- Co-authored-by: cor <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was reading an epub that contained superscripts that weren't being rendered, so I made this PR.
This adds:
I generated apps for all of the scripts because I wasn't sure which ones are relevant in the flow.
I flashed this firmware myself and it was working well.
NOTE: This does not introduce fully reproducible builds, as wrapping PlatformIO in Nix is outside of my skillset. Instead it introduces a reproducible environment in which platformIO can be ran on Nix machines, which should be reasonably reproducible for now.