Add expat and swap out EPUB HTML parser#2

Merged

daveallie merged 4 commits intomasterfrom

Dec 6, 2025

Member

daveallie commented Dec 6, 2025

Rebuild HTML parsing using expat
Potential to swap out the rest of the parsing to use expat in the future

daveallie added 4 commits

December 6, 2025 19:41


          Add expat and swap out ERB HTML parser

a33ac25


          Increase EpubHtmlParserSlim file buffer to 1024 bytes

74f7ea9


          Cleanup TextBlock functions

d5a220f


          Do not break words when leaving spans

0a67a3d

daveallie merged commit dd6e649 into master

daveallie deleted the feature/expat branch

December 8, 2025 12:13

martinbrook pushed a commit to martinbrook/crosspoint-reader that referenced this pull request


          refactor: extract shared DitherUtils.h and PixelCache.h

b6555e1

Address review comments crosspoint-reader#2, crosspoint-reader#3, and crosspoint-reader#10:
- Extract duplicated bayer4x4 matrix, applyBayerDither4Level(), and
  drawPixelWithRenderMode() into shared DitherUtils.h
- Extract duplicated PixelCache struct into shared PixelCache.h so both
  JPEG and PNG decoders use the same implementation
- Add MAX_CACHE_BYTES (256KB) size limit to PixelCache::allocate() to
  proactively guard against oversized allocations on embedded targets

martinbrook pushed a commit to martinbrook/crosspoint-reader that referenced this pull request


          refactor: use shared DitherUtils and PixelCache in JPEG decoder

1bba595

Address review comments crosspoint-reader#2 and crosspoint-reader#3:
- Remove duplicated bayer4x4, applyBayerDither4Level(),
  drawPixelWithRenderMode(), and PixelCache from JPEG decoder
- Include shared DitherUtils.h and PixelCache.h instead

martinbrook added a commit to martinbrook/crosspoint-reader that referenced this pull request


          refactor: extract shared DitherUtils.h and PixelCache.h

a345152

Address review comments crosspoint-reader#2, crosspoint-reader#3, and crosspoint-reader#10:
- Extract duplicated bayer4x4 matrix, applyBayerDither4Level(), and
  drawPixelWithRenderMode() into shared DitherUtils.h
- Extract duplicated PixelCache struct into shared PixelCache.h so both
  JPEG and PNG decoders use the same implementation
- Add MAX_CACHE_BYTES (256KB) size limit to PixelCache::allocate() to
  proactively guard against oversized allocations on embedded targets

martinbrook added a commit to martinbrook/crosspoint-reader that referenced this pull request


          refactor: use shared DitherUtils and PixelCache in JPEG decoder

ea5b2c0

Address review comments crosspoint-reader#2 and crosspoint-reader#3:
- Remove duplicated bayer4x4, applyBayerDither4Level(),
  drawPixelWithRenderMode(), and PixelCache from JPEG decoder
- Include shared DitherUtils.h and PixelCache.h instead

martinbrook mentioned this pull request

feat: add png jpeg support #556

Merged

8 tasks

martinbrook added a commit to martinbrook/crosspoint-reader that referenced this pull request


          refactor: extract shared DitherUtils.h and PixelCache.h

b8e6113

Address review comments crosspoint-reader#2, crosspoint-reader#3, and crosspoint-reader#10:
- Extract duplicated bayer4x4 matrix, applyBayerDither4Level(), and
  drawPixelWithRenderMode() into shared DitherUtils.h
- Extract duplicated PixelCache struct into shared PixelCache.h so both
  JPEG and PNG decoders use the same implementation
- Add MAX_CACHE_BYTES (256KB) size limit to PixelCache::allocate() to
  proactively guard against oversized allocations on embedded targets

martinbrook added a commit to martinbrook/crosspoint-reader that referenced this pull request


          refactor: use shared DitherUtils and PixelCache in JPEG decoder

12b1e8e

Address review comments crosspoint-reader#2 and crosspoint-reader#3:
- Remove duplicated bayer4x4, applyBayerDither4Level(),
  drawPixelWithRenderMode(), and PixelCache from JPEG decoder
- Include shared DitherUtils.h and PixelCache.h instead

lukestein pushed a commit that referenced this pull request


          refactor: extract shared DitherUtils.h and PixelCache.h

951e59b

Address review comments #2, #3, and #10:
- Extract duplicated bayer4x4 matrix, applyBayerDither4Level(), and
  drawPixelWithRenderMode() into shared DitherUtils.h
- Extract duplicated PixelCache struct into shared PixelCache.h so both
  JPEG and PNG decoders use the same implementation
- Add MAX_CACHE_BYTES (256KB) size limit to PixelCache::allocate() to
  proactively guard against oversized allocations on embedded targets

lukestein pushed a commit that referenced this pull request


          refactor: use shared DitherUtils and PixelCache in JPEG decoder

51d24e0

Address review comments #2 and #3:
- Remove duplicated bayer4x4, applyBayerDither4Level(),
  drawPixelWithRenderMode(), and PixelCache from JPEG decoder
- Include shared DitherUtils.h and PixelCache.h instead

martinbrook added a commit to martinbrook/crosspoint-reader that referenced this pull request


          refactor: extract shared DitherUtils.h and PixelCache.h

73818ed

Address review comments crosspoint-reader#2, crosspoint-reader#3, and crosspoint-reader#10:
- Extract duplicated bayer4x4 matrix, applyBayerDither4Level(), and
  drawPixelWithRenderMode() into shared DitherUtils.h
- Extract duplicated PixelCache struct into shared PixelCache.h so both
  JPEG and PNG decoders use the same implementation
- Add MAX_CACHE_BYTES (256KB) size limit to PixelCache::allocate() to
  proactively guard against oversized allocations on embedded targets

martinbrook added a commit to martinbrook/crosspoint-reader that referenced this pull request


          refactor: use shared DitherUtils and PixelCache in JPEG decoder

35c292e

Address review comments crosspoint-reader#2 and crosspoint-reader#3:
- Remove duplicated bayer4x4, applyBayerDither4Level(),
  drawPixelWithRenderMode(), and PixelCache from JPEG decoder
- Include shared DitherUtils.h and PixelCache.h instead

martinbrook added a commit to martinbrook/crosspoint-reader that referenced this pull request


          refactor: extract shared DitherUtils.h and PixelCache.h

4f85e2a

Address review comments crosspoint-reader#2, crosspoint-reader#3, and crosspoint-reader#10:
- Extract duplicated bayer4x4 matrix, applyBayerDither4Level(), and
  drawPixelWithRenderMode() into shared DitherUtils.h
- Extract duplicated PixelCache struct into shared PixelCache.h so both
  JPEG and PNG decoders use the same implementation
- Add MAX_CACHE_BYTES (256KB) size limit to PixelCache::allocate() to
  proactively guard against oversized allocations on embedded targets

martinbrook added a commit to martinbrook/crosspoint-reader that referenced this pull request


          refactor: use shared DitherUtils and PixelCache in JPEG decoder

34fff0f

Address review comments crosspoint-reader#2 and crosspoint-reader#3:
- Remove duplicated bayer4x4, applyBayerDither4Level(),
  drawPixelWithRenderMode(), and PixelCache from JPEG decoder
- Include shared DitherUtils.h and PixelCache.h instead

FetchFast mentioned this pull request

feat: current screen as lock screen #410

Open

martinbrook added a commit to martinbrook/crosspoint-reader that referenced this pull request


          refactor: extract shared DitherUtils.h and PixelCache.h

7d54be0

Address review comments crosspoint-reader#2, crosspoint-reader#3, and crosspoint-reader#10:
- Extract duplicated bayer4x4 matrix, applyBayerDither4Level(), and
  drawPixelWithRenderMode() into shared DitherUtils.h
- Extract duplicated PixelCache struct into shared PixelCache.h so both
  JPEG and PNG decoders use the same implementation
- Add MAX_CACHE_BYTES (256KB) size limit to PixelCache::allocate() to
  proactively guard against oversized allocations on embedded targets

martinbrook added a commit to martinbrook/crosspoint-reader that referenced this pull request


          refactor: use shared DitherUtils and PixelCache in JPEG decoder

0c2054b

Address review comments crosspoint-reader#2 and crosspoint-reader#3:
- Remove duplicated bayer4x4, applyBayerDither4Level(),
  drawPixelWithRenderMode(), and PixelCache from JPEG decoder
- Include shared DitherUtils.h and PixelCache.h instead

madeddie pushed a commit to madeddie/crosspoint-reader that referenced this pull request


          refactor: extract shared DitherUtils.h and PixelCache.h

fcf152e

Address review comments crosspoint-reader#2, crosspoint-reader#3, and crosspoint-reader#10:
- Extract duplicated bayer4x4 matrix, applyBayerDither4Level(), and
  drawPixelWithRenderMode() into shared DitherUtils.h
- Extract duplicated PixelCache struct into shared PixelCache.h so both
  JPEG and PNG decoders use the same implementation
- Add MAX_CACHE_BYTES (256KB) size limit to PixelCache::allocate() to
  proactively guard against oversized allocations on embedded targets

madeddie pushed a commit to madeddie/crosspoint-reader that referenced this pull request


          refactor: use shared DitherUtils and PixelCache in JPEG decoder

fe0de9f

Address review comments crosspoint-reader#2 and crosspoint-reader#3:
- Remove duplicated bayer4x4, applyBayerDither4Level(),
  drawPixelWithRenderMode(), and PixelCache from JPEG decoder
- Include shared DitherUtils.h and PixelCache.h instead

martinbrook added a commit to martinbrook/crosspoint-reader that referenced this pull request


          refactor: extract shared DitherUtils.h and PixelCache.h

2bbbcc6

Address review comments crosspoint-reader#2, crosspoint-reader#3, and crosspoint-reader#10:
- Extract duplicated bayer4x4 matrix, applyBayerDither4Level(), and
  drawPixelWithRenderMode() into shared DitherUtils.h
- Extract duplicated PixelCache struct into shared PixelCache.h so both
  JPEG and PNG decoders use the same implementation
- Add MAX_CACHE_BYTES (256KB) size limit to PixelCache::allocate() to
  proactively guard against oversized allocations on embedded targets

martinbrook added a commit to martinbrook/crosspoint-reader that referenced this pull request


          refactor: use shared DitherUtils and PixelCache in JPEG decoder

3d80385

Address review comments crosspoint-reader#2 and crosspoint-reader#3:
- Remove duplicated bayer4x4, applyBayerDither4Level(),
  drawPixelWithRenderMode(), and PixelCache from JPEG decoder
- Include shared DitherUtils.h and PixelCache.h instead

Danbrose pushed a commit to Danbrose/crosspoint-reader that referenced this pull request


          russian translation (crosspoint-reader#2)

605eb7d

* feat: add extra small fonz sizes

* added spanish string

* fix formatting

* reodered `FONT_SIZE` enum for keep old order

* add romanian string

* fix: setting now corresponds to font (error introduced in 072a44c)

* Update russian.yaml

Added line 176 with the translation of "extra small" font size

---------

Co-authored-by: Ariel Lindemann <[email protected]>

vjapolitzer pushed a commit to vjapolitzer/crosspoint-reader that referenced this pull request


          Merge pull request crosspoint-reader#2 from vjapolitzer/x3-support

a8e209c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet