Skip to content

chore: new Ukrainian localization strings#1270

Merged
znelson merged 1 commit intocrosspoint-reader:masterfrom
mirus-ua:feat/ukrainian-translation-mar-2
Mar 3, 2026
Merged

chore: new Ukrainian localization strings#1270
znelson merged 1 commit intocrosspoint-reader:masterfrom
mirus-ua:feat/ukrainian-translation-mar-2

Conversation

@mirus-ua
Copy link
Contributor

@mirus-ua mirus-ua commented Mar 2, 2026

Summary

  • What changes are included?
    New Ukrainian localization strings

Additional Context

auto turn functionality #1219

AI Usage

While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it
helps set the right context for reviewers.

Did you use AI tools to help write this code? **NO **

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 2, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7dc5186 and 50b9abb.

📒 Files selected for processing (1)
  • lib/I18n/translations/ukrainian.yaml
📜 Recent review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build
  • GitHub Check: cppcheck
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2026-02-23T22:11:42.181Z 
Learnt from: ariel-lindemann
Repo: crosspoint-reader/crosspoint-reader PR: 1133
File: lib/I18n/translations/finnish.yaml:92-92
Timestamp: 2026-02-23T22:11:42.181Z
Learning: In translation YAML files located in lib/I18n/translations/, literal percent signs (%) in strings (e.g., STR_HIDE_BATTERY, STR_GO_TO_PERCENT, STR_PERCENT_STEP_HINT) do not require escaping as %% and this convention is consistent across all language translations. Ensure that this pattern is followed for all YAML files in this directory to avoid introducing incorrect formatting markers in localized strings.

Applied to files:

  • lib/I18n/translations/ukrainian.yaml
🔇 Additional comments (2)
lib/I18n/translations/ukrainian.yaml (2)

300-300: STR_DELETE addition looks consistent and correct.

This key/value is valid and aligns with existing Ukrainian terminology used in this file.

338-339: Auto-turn localization keys are well-formed.

Both new strings are syntactically correct and consistent with the file’s translation key patterns.

📝 Walkthrough

Walkthrough

Three new Ukrainian translation keys are added to the language file: STR_DELETE for delete action, and STR_AUTO_TURN_ENABLED and STR_AUTO_TURN_PAGES_PER_MIN for auto-page-turn feature UI strings. No existing translations are modified.

Changes

Cohort / File(s) Summary
Translation Keys
lib/I18n/translations/ukrainian.yaml		 Added 3 new Ukrainian translation entries for delete action and auto-page-turn feature settings.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • #1227: Adds the same auto-page-turn translation keys (STR_AUTO_TURN_ENABLED and STR_AUTO_TURN_PAGES_PER_MIN) to the Ukrainian translation file
  • #1149: Adds new Ukrainian translation keys to the same translation resource file
  • #1199: Modifies the same Ukrainian translation file with additional UI string keys

Suggested reviewers

  • znelson
  • osteotek
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: adding new localization strings to the Ukrainian translation file.
Description check ✅ Passed The description is directly related to the changeset, specifying that new Ukrainian localization strings are being added, with supporting context about the auto turn functionality.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mirus-ua mirus-ua changed the title chore: new localization strings chore: new Ukrainian localization strings Mar 2, 2026
jonasdiemer
jonasdiemer approved these changes Mar 2, 2026
View reviewed changes
Copy link
Contributor

@jonasdiemer jonasdiemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable (but I don't speak Ukrainian)

@znelson znelson merged commit 6de8b7a into crosspoint-reader:master Mar 3, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@znelson znelson znelson approved these changes

@jonasdiemer jonasdiemer jonasdiemer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mirus-ua @znelson @jonasdiemer