fix: Hide unusable button hints when viewing empty directory#1253
fix: Hide unusable button hints when viewing empty directory#1253daveallie merged 3 commits intocrosspoint-reader:masterfrom
Conversation
file browser shows more than just books so saying no books found when viewing an empty directory doesn't make sense
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (18)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🧰 Additional context used🧠 Learnings (5)📓 Common learnings📚 Learning: 2026-02-16T22:25:35.674ZApplied to files:
📚 Learning: 2026-02-23T22:11:42.181ZApplied to files:
📚 Learning: 2026-02-12T06:57:35.955ZApplied to files:
📚 Learning: 2026-02-27T22:49:59.600ZApplied to files:
🔇 Additional comments (19)
📝 WalkthroughWalkthroughTranslation key Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
znelson
left a comment
znelson
left a comment
There was a problem hiding this comment.
Can't comment on the localization, but the button label logic makes sense to me
…int-reader#1253) * **What is the goal of this PR?** Increase accuracy of button hints and text description in the file browser when viewing empty directory. * **What changes are included?** Adjusted button label hint rendering logic in file browser to hide the "Open", "Up", and "Down" hints when the they are not available due to an empty directory. I also changed the NO_BOOKS_FOUND string to NO_FILES_FOUND and updated translations. File browser shows more than just books so seeing "No Books Found" really doesn't make sense. Very Simple change, here is what that looks like on my device. <img width="1318" height="879" alt="Untitled (7)" src="https://github.com/user-attachments/assets/6416c8c8-795d-41a5-9b9f-28d2c26666a0" /> --- While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**NO**_
Cherry-picked upstream fixes and features applied via rescue-1.0.0 worktree: - fix: properly implement requestUpdateAndWait() (crosspoint-reader#1218) - fix: Hide unusable button hints in empty directory (crosspoint-reader#1253) - fix: add missing keyboard metrics to Lyra3CoversTheme (crosspoint-reader#1101) - fix: remove bookProgressBarHeight from Lyra3CoversTheme - feat: replace picojpeg with JPEGDEC for JPEG decoding (crosspoint-reader#1136) - feat: WIFI pill, feed log fix, JPEGDEC version string - feat: Add git branch to version string (crosspoint-reader#1225) - fix: navigate directly to QR code after DZ auto-connect - perf: Removed unused ConfirmationActivity member (crosspoint-reader#1234) - refactor: Simplify new setting introduction (crosspoint-reader#1086) - fix: UI fonts, settings stack overflow, PULSR theme name - fix: convert SettingsList to push_back (prevent stack overflow) All commits built and verified on device (confirmed 1.1.0-dev+d1e786a).
|
@Levrk thank you for the contribution, In the future would you please tag the translators, so we can give our input on the translations? Or you can also leave them unchanged and we will see they need translating. But the way it's done here there is the danger that we miss it completely and some translations might be wrong. At least the Romanian one I would have done differently. And also the German and French are techinically correct but not in line with the overall style of the translations. So you're introducing changes which are out of scope and the ones responsible aren't notified. I'm sure you meant well and thank you for your work |
|
@ariel-lindemann Absolutely, I will be more mindful of this moving forward. Is there a standard method to notify translators, or would I tag folks individually? Perhaps we should have an ongoing discussion post where PR's with translation updates can be linked for visibility. |
4 participants
Summary
Increase accuracy of button hints and text description in the file browser when viewing empty directory.
Adjusted button label hint rendering logic in file browser to hide the "Open", "Up", and "Down" hints when the they are not available due to an empty directory.
I also changed the NO_BOOKS_FOUND string to NO_FILES_FOUND and updated translations. File browser shows more than just books so seeing "No Books Found" really doesn't make sense.
Additional Context
Very Simple change, here is what that looks like on my device.
AI Usage
While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it
helps set the right context for reviewers.
Did you use AI tools to help write this code? NO