perf: Removed unused ConfirmationActivity member#1234
Merged
znelson merged 1 commit intocrosspoint-reader:masterfrom Mar 1, 2026
Merged
perf: Removed unused ConfirmationActivity member#1234znelson merged 1 commit intocrosspoint-reader:masterfrom
znelson merged 1 commit intocrosspoint-reader:masterfrom
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughTwo cleanup changes across the codebase: removal of an unused private data member Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 1 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
osteotek
approved these changes
Mar 1, 2026
ngxson
approved these changes
Mar 1, 2026
Closed
9 tasks
laird
pushed a commit
to laird/crosspoint-claw
that referenced
this pull request
Mar 1, 2026
) ## Summary **What is the goal of this PR?** Small follow up to crosspoint-reader#909, removing an unused member variable and some temporary debug logging. --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**NO**_
laird
added a commit
to laird/crosspoint-claw
that referenced
this pull request
Mar 1, 2026
Cherry-picked upstream fixes and features applied via rescue-1.0.0 worktree: - fix: properly implement requestUpdateAndWait() (crosspoint-reader#1218) - fix: Hide unusable button hints in empty directory (crosspoint-reader#1253) - fix: add missing keyboard metrics to Lyra3CoversTheme (crosspoint-reader#1101) - fix: remove bookProgressBarHeight from Lyra3CoversTheme - feat: replace picojpeg with JPEGDEC for JPEG decoding (crosspoint-reader#1136) - feat: WIFI pill, feed log fix, JPEGDEC version string - feat: Add git branch to version string (crosspoint-reader#1225) - fix: navigate directly to QR code after DZ auto-connect - perf: Removed unused ConfirmationActivity member (crosspoint-reader#1234) - refactor: Simplify new setting introduction (crosspoint-reader#1086) - fix: UI fonts, settings stack overflow, PULSR theme name - fix: convert SettingsList to push_back (prevent stack overflow) All commits built and verified on device (confirmed 1.1.0-dev+d1e786a).
trilwu
added a commit
to trilwu/crosspet
that referenced
this pull request
Mar 2, 2026
…actors) Merges upstream commits: - fix: fixed-point x-advance and kerning for text layout (crosspoint-reader#1168) - chore: add firmware size history script (crosspoint-reader#1235) - refactor: binary search for font lookups (crosspoint-reader#1202) - perf: remove unused ConfirmationActivity member (crosspoint-reader#1234) Resolved conflicts in ubuntu_10/12 bold/regular font headers by accepting upstream regenerated values (local had no changes to these files).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What is the goal of this PR?
Small follow up to #909, removing an unused member variable and some temporary debug logging.
AI Usage
While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it
helps set the right context for reviewers.
Did you use AI tools to help write this code? NO