chore: new Ukrainian translation lines#1199
Merged
znelson merged 4 commits intocrosspoint-reader:masterfrom Feb 26, 2026
Merged
chore: new Ukrainian translation lines#1199znelson merged 4 commits intocrosspoint-reader:masterfrom
znelson merged 4 commits intocrosspoint-reader:masterfrom
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
📝 WalkthroughWalkthroughAdds 21 new Ukrainian localization keys for UI elements (progress bar, book/chapter labels, footnotes, battery, QR display, caps/directions, etc.) in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@lib/I18n/translations/ukrainian.yaml`:
- Around line 263-264: STR_CHAPTER and STR_EXAMPLE_CHAPTER use "Глава" but the
rest of the translation set (e.g., STR_SELECT_CHAPTER, STR_CHAPTER_PREFIX,
STR_SECTION_PREFIX) use "Розділ"; update STR_CHAPTER and STR_EXAMPLE_CHAPTER to
use "Розділ" (and adjust the example string accordingly) so terminology is
consistent across the translation entries.
- Around line 334-336: Replace the awkward Ukrainian phrase for the
STR_NO_FOOTNOTES translation: change the current value for STR_NO_FOOTNOTES to a
more natural construction by using "Сторінка не має зносок" (note the space
between "не" and "має") so the key STR_NO_FOOTNOTES reads correctly.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
lib/I18n/translations/ukrainian.yaml
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: build
- GitHub Check: cppcheck
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2026-02-23T22:11:42.181Z
Learnt from: ariel-lindemann
Repo: crosspoint-reader/crosspoint-reader PR: 1133
File: lib/I18n/translations/finnish.yaml:92-92
Timestamp: 2026-02-23T22:11:42.181Z
Learning: In translation YAML files located in lib/I18n/translations/, literal percent signs (%) in strings (e.g., STR_HIDE_BATTERY, STR_GO_TO_PERCENT, STR_PERCENT_STEP_HINT) do not require escaping as %% and this convention is consistent across all language translations. Ensure that this pattern is followed for all YAML files in this directory to avoid introducing incorrect formatting markers in localized strings.
Applied to files:
lib/I18n/translations/ukrainian.yaml
🔇 Additional comments (5)
lib/I18n/translations/ukrainian.yaml (5)
237-238: LGTM!The translations for "Show" and "Hide" are correct and idiomatic Ukrainian.
254-262: LGTM!The status bar and progress bar translations are accurate and follow appropriate Ukrainian terminology.
265-268: LGTM!The preview, title, and battery translations are correct.
271-272: LGTM!The theme names are properly transliterated to Ukrainian Cyrillic, which is appropriate for full localization.
301-301: LGTM!The QR code display string is correctly translated.
osteotek
reviewed
Feb 26, 2026
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@lib/I18n/translations/ukrainian.yaml`:
- Around line 254-258: Update the Ukrainian translations to fix mid-phrase
capitalization and use the correct noun case for "рядок/рядка": change
STR_CUSTOMISE_STATUS_BAR to "Налаштувати рядок стану" (lowercase "рядок"),
change STR_PROGRESS_BAR to "Рядок прогресу" -> preferably "рядок прогресу"
(lowercase), and change STR_PROGRESS_BAR_THICKNESS from "Товщина Рядку прогресу"
to "Товщина рядка прогресу" (correct genitive case "рядка" and lowercase),
leaving other keys (e.g., STR_BOOK_PROGRESS_PERCENTAGE, STR_CHAPTER_PAGE_COUNT)
unchanged unless consistency requires lowercasing non-initial nouns.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
lib/I18n/translations/ukrainian.yaml
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: build
- GitHub Check: cppcheck
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2026-02-23T22:11:42.181Z
Learnt from: ariel-lindemann
Repo: crosspoint-reader/crosspoint-reader PR: 1133
File: lib/I18n/translations/finnish.yaml:92-92
Timestamp: 2026-02-23T22:11:42.181Z
Learning: In translation YAML files located in lib/I18n/translations/, literal percent signs (%) in strings (e.g., STR_HIDE_BATTERY, STR_GO_TO_PERCENT, STR_PERCENT_STEP_HINT) do not require escaping as %% and this convention is consistent across all language translations. Ensure that this pattern is followed for all YAML files in this directory to avoid introducing incorrect formatting markers in localized strings.
Applied to files:
lib/I18n/translations/ukrainian.yaml
📚 Learning: 2026-02-16T22:25:35.674Z
Learnt from: whyte-j
Repo: crosspoint-reader/crosspoint-reader PR: 733
File: lib/I18n/I18nKeys.h:271-272
Timestamp: 2026-02-16T22:25:35.674Z
Learning: In the crosspoint-reader i18n system (lib/I18n/), missing translation keys in non-English YAML files are automatically filled with English strings at build time by the gen_i18n.py script. All generated string arrays (STRINGS_EN, STRINGS_ES, etc.) have identical lengths, so runtime array indexing is safe without per-string fallback logic. The system prints "INFO: '{key}' missing in {lang_code}, using English fallback" during code generation when this occurs.
Applied to files:
lib/I18n/translations/ukrainian.yaml
🔇 Additional comments (5)
lib/I18n/translations/ukrainian.yaml (5)
237-238: Good addition for visibility actions.
STR_SHOW/STR_HIDEare clear, concise, and consistent with surrounding UI labels.
255-257: Nice coverage of new progress/book metadata keys.These translations read naturally and match the terminology used elsewhere in this locale file.
Also applies to: 259-268
271-272: Theme name localization looks good.
STR_THEME_LYRAandSTR_THEME_LYRA_EXTENDEDare now properly localized.
301-301: QR display label is clear and actionable.This wording is understandable in context and consistent with nearby QR-related hints.
334-336: Footnotes block wording is now natural.
STR_NO_FOOTNOTESand adjacent labels are grammatically solid and user-friendly.
osteotek
approved these changes
Feb 26, 2026
znelson
approved these changes
Feb 26, 2026
el
pushed a commit
to el/crosspoint-reader
that referenced
this pull request
Feb 26, 2026
## Summary * **What is the goal of this PR?** Update translation after crosspoint-reader#733 --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**NO**_
iandchasse
pushed a commit
to iandchasse/crosspoint-reader-minRead
that referenced
this pull request
Feb 27, 2026
* **What is the goal of this PR?** Update translation after crosspoint-reader#733 --- While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**NO**_
This was referenced Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update translation after feat: split status bar setting #733
AI Usage
While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it
helps set the right context for reviewers.
Did you use AI tools to help write this code? NO