Skip to content

chore: Update russian.yaml#1198

Merged
znelson merged 1 commit intocrosspoint-reader:masterfrom
madebyKir:russian.yaml
Feb 26, 2026
Merged

chore: Update russian.yaml#1198
znelson merged 1 commit intocrosspoint-reader:masterfrom
madebyKir:russian.yaml

Conversation

@madebyKir
Copy link
Contributor

Summary

Translation added russian.yaml

Additional Context

  • Add any other information that might be helpful for the reviewer (e.g., performance implications, potential risks,
    specific areas to focus on).

AI Usage

While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it
helps set the right context for reviewers.

Did you use AI tools to help write this code? < YES | PARTIALLY | NO >
NO

update russian.yaml
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 451774d and 600bd07.

📒 Files selected for processing (1)
  • lib/I18n/translations/russian.yaml
📜 Recent review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build
  • GitHub Check: cppcheck
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2026-02-23T22:11:42.181Z
Learnt from: ariel-lindemann
Repo: crosspoint-reader/crosspoint-reader PR: 1133
File: lib/I18n/translations/finnish.yaml:92-92
Timestamp: 2026-02-23T22:11:42.181Z
Learning: In translation YAML files located in lib/I18n/translations/, literal percent signs (%) in strings (e.g., STR_HIDE_BATTERY, STR_GO_TO_PERCENT, STR_PERCENT_STEP_HINT) do not require escaping as %% and this convention is consistent across all language translations. Ensure that this pattern is followed for all YAML files in this directory to avoid introducing incorrect formatting markers in localized strings.

Applied to files:

  • lib/I18n/translations/russian.yaml
🔇 Additional comments (3)
lib/I18n/translations/russian.yaml (3)

238-239: LGTM!

The translations for "Show" and "Hide" are accurate and consistent with other UI action strings in the file.


254-267: LGTM!

All status bar customization translations are accurate and follow established patterns. The percent sign in STR_BOOK_PROGRESS_PERCENTAGE correctly uses % without escaping, consistent with other translations in this directory. Based on learnings: "In translation YAML files located in lib/I18n/translations/, literal percent signs (%) in strings do not require escaping."


301-301: LGTM!

The QR display translation is accurate with correct Russian grammar (genitive case "QR-кода") and consistent terminology with other QR-related strings in the file.


📝 Walkthrough

Walkthrough

This pull request adds 17 new translation keys to the Russian language file, introducing UI text for visibility controls, status bar customization, page/chapter metadata, progress visualization components, and QR display functionality without modifying existing translations.

Changes

Cohort / File(s) Summary
Russian Translation Keys
lib/I18n/translations/russian.yaml
Added 17 new Russian translation strings for UI controls (STR_SHOW, STR_HIDE), status bar customization (STR_CUSTOMISE_STATUS_BAR, STR_CHAPTER_PAGE_COUNT, STR_BOOK_PROGRESS_PERCENTAGE), progress visualization options (STR_PROGRESS_BAR and related properties), metadata labels (STR_BOOK, STR_CHAPTER, STR_BATTERY), preview/display functionality (STR_DISPLAY_QR, STR_PREVIEW), and example content (STR_EXAMPLE_BOOK, STR_TITLE).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • osteotek
  • znelson
🚥 Pre-merge checks | ✅ 1 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is overly vague and generic, using 'Update russian.yaml' without specifying what translations or features are being added. Consider a more descriptive title that indicates the scope of changes, such as 'chore: Add Russian translations for visibility controls and status bar customization'.
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The description is minimal but does indicate that translations were added to russian.yaml, which aligns with the changeset.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@znelson znelson merged commit 3f98a87 into crosspoint-reader:master Feb 26, 2026
7 checks passed
el pushed a commit to el/crosspoint-reader that referenced this pull request Feb 26, 2026
## Summary

Translation added russian.yaml

## Additional Context 

* Add any other information that might be helpful for the reviewer
(e.g., performance implications, potential risks,
  specific areas to focus on).

---

### AI Usage

While CrossPoint doesn't have restrictions on AI tools in contributing,
please be transparent about their usage as it
helps set the right context for reviewers.

Did you use AI tools to help write this code? _**< YES | PARTIALLY | NO
>**_
NO
iandchasse pushed a commit to iandchasse/crosspoint-reader-minRead that referenced this pull request Feb 27, 2026
Translation added russian.yaml

* Add any other information that might be helpful for the reviewer
(e.g., performance implications, potential risks,
  specific areas to focus on).

---

While CrossPoint doesn't have restrictions on AI tools in contributing,
please be transparent about their usage as it
helps set the right context for reviewers.

Did you use AI tools to help write this code? _**< YES | PARTIALLY | NO
>**_
NO
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants