feat: Polish translation tweaks#1193
Conversation
with new status bar settings
add missing tranlations
📝 WalkthroughWalkthroughAdds Polish localization updates: documents Polish as supported and updates numerous Polish translation strings in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@lib/I18n/translations/polish.yaml`:
- Line 311: The Polish translation for the key STR_CALC_HASH contains a grammar
typo ("sumu kontrolnej"); update the value of STR_CALC_HASH to use the correct
form "sumy kontrolnej" so the string reads "Obliczanie sumy kontrolnej...".
Locate STR_CALC_HASH in the translations (polish.yaml) and replace the incorrect
word while keeping the rest of the text unchanged.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
docs/i18n.mdlib/I18n/translations/polish.yaml
📜 Review details
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2026-02-23T22:11:42.181Z
Learnt from: ariel-lindemann
Repo: crosspoint-reader/crosspoint-reader PR: 1133
File: lib/I18n/translations/finnish.yaml:92-92
Timestamp: 2026-02-23T22:11:42.181Z
Learning: In translation YAML files located in lib/I18n/translations/, literal percent signs (%) in strings (e.g., STR_HIDE_BATTERY, STR_GO_TO_PERCENT, STR_PERCENT_STEP_HINT) do not require escaping as %% and this convention is consistent across all language translations. Ensure that this pattern is followed for all YAML files in this directory to avoid introducing incorrect formatting markers in localized strings.
Applied to files:
lib/I18n/translations/polish.yaml
🔇 Additional comments (2)
lib/I18n/translations/polish.yaml (1)
309-309: Percent formatting is correct in this translation key.Line 309 correctly uses literal
%characters and should stay as-is (no%%escaping needed).Based on learnings: literal percent signs in
lib/I18n/translations/*.yamlshould remain unescaped.docs/i18n.md (1)
16-16: Supported languages list update looks good.Line 16 correctly adds Polish to documentation and matches the translation updates in this PR.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@lib/I18n/translations/polish.yaml`:
- Line 66: Update the Polish translation key STR_TO_PREFIX to use the
destination-oriented prefix "do " (matching other locales) instead of the
current "Z "; locate STR_TO_PREFIX in the Polish translations (symbol:
STR_TO_PREFIX) and replace its value with "do " so concatenations that build "to
<SSID>" render correctly.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
docs/i18n.mdlib/I18n/translations/polish.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
- docs/i18n.md
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: cppcheck
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: ariel-lindemann
Repo: crosspoint-reader/crosspoint-reader PR: 1133
File: lib/I18n/translations/finnish.yaml:92-92
Timestamp: 2026-02-23T22:11:51.854Z
Learning: In translation YAML files under `lib/I18n/translations/`, literal percent signs (`%`) in strings like STR_HIDE_BATTERY, STR_GO_TO_PERCENT, and STR_PERCENT_STEP_HINT do not need to be escaped as `%%`. This is the established pattern across all language translations and does not cause formatting errors.
📚 Learning: 2026-02-23T22:11:42.181Z
Learnt from: ariel-lindemann
Repo: crosspoint-reader/crosspoint-reader PR: 1133
File: lib/I18n/translations/finnish.yaml:92-92
Timestamp: 2026-02-23T22:11:42.181Z
Learning: In translation YAML files located in lib/I18n/translations/, literal percent signs (%) in strings (e.g., STR_HIDE_BATTERY, STR_GO_TO_PERCENT, STR_PERCENT_STEP_HINT) do not require escaping as %% and this convention is consistent across all language translations. Ensure that this pattern is followed for all YAML files in this directory to avoid introducing incorrect formatting markers in localized strings.
Applied to files:
lib/I18n/translations/polish.yaml
🔇 Additional comments (5)
lib/I18n/translations/polish.yaml (5)
90-104: These settings-label tweaks look consistent and clearer.The shortened wording for sleep-cover/button/font labels reads cleaner and is UI-friendly with no formatting-risk markers introduced.
163-186: Navigation/typography abbreviations look coherent.The updated short forms (
Poprz./Nast.,Nast./Poprz., alignment/spacing labels) are internally consistent and suitable for constrained UI space.
223-256: Good normalization of toggle/state/status-bar terminology.
Karta SD,Zmień,Wł./Wył., and related status-bar wording changes improve consistency across controls.
309-309: Percent-step hint formatting is correct as-is.Keeping literal
%unescaped in this YAML string matches the established translation pattern and avoids introducing incorrect markers.
Based on learnings: In translation YAML files underlib/I18n/translations/, literal percent signs (%) should not be escaped as%%.
311-332: Hash-status grammar fix and EPUB style wording are good.
STR_CALC_HASHnow uses correct Polish grammar, andSTR_EMBEDDED_STYLEis clear and specific.
3 participants
Summary
Additional Context
specific areas to focus on).
AI Usage
While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it
helps set the right context for reviewers.
Did you use AI tools to help write this code? < YES | PARTIALLY | NO >