fix: add missing romanian strings#1187
Merged
osteotek merged 2 commits intocrosspoint-reader:masterfrom Feb 26, 2026
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughUpdates the Romanian translation file by adding 18 new localization keys (UI, progress bar, book/chapter metadata, battery, preview/title) and removing one obsolete key. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@lib/I18n/translations/romanian.yaml`:
- Line 301: Update the Romanian translation for STR_DISPLAY_QR to use the
definite form of "page": replace the current value "Afișați pagină ca cod QR"
with "Afișați pagina ca cod QR" so the label reads correctly; modify the string
associated with STR_DISPLAY_QR in the translations file.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
lib/I18n/translations/romanian.yaml
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: cppcheck
- GitHub Check: build
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2026-02-23T22:11:42.181Z
Learnt from: ariel-lindemann
Repo: crosspoint-reader/crosspoint-reader PR: 1133
File: lib/I18n/translations/finnish.yaml:92-92
Timestamp: 2026-02-23T22:11:42.181Z
Learning: In translation YAML files located in lib/I18n/translations/, literal percent signs (%) in strings (e.g., STR_HIDE_BATTERY, STR_GO_TO_PERCENT, STR_PERCENT_STEP_HINT) do not require escaping as %% and this convention is consistent across all language translations. Ensure that this pattern is followed for all YAML files in this directory to avoid introducing incorrect formatting markers in localized strings.
Applied to files:
lib/I18n/translations/romanian.yaml
📚 Learning: 2026-02-16T22:25:35.674Z
Learnt from: whyte-j
Repo: crosspoint-reader/crosspoint-reader PR: 733
File: lib/I18n/I18nKeys.h:271-272
Timestamp: 2026-02-16T22:25:35.674Z
Learning: In the crosspoint-reader i18n system (lib/I18n/), missing translation keys in non-English YAML files are automatically filled with English strings at build time by the gen_i18n.py script. All generated string arrays (STRINGS_EN, STRINGS_ES, etc.) have identical lengths, so runtime array indexing is safe without per-string fallback logic. The system prints "INFO: '{key}' missing in {lang_code}, using English fallback" during code generation when this occurs.
Applied to files:
lib/I18n/translations/romanian.yaml
🔇 Additional comments (2)
lib/I18n/translations/romanian.yaml (2)
238-239: Good additions for generic visibility actions.
STR_SHOWandSTR_HIDEare clear and consistent with the rest of the UI action vocabulary.
254-268: Status-bar translation block looks complete and coherent.This set is comprehensive and internally consistent for the new customization UI.
znelson
previously approved these changes
Feb 25, 2026
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
lib/I18n/translations/romanian.yaml (1)
254-254: Consider terminology consistency for status bar customization.Line 254 uses
Customizaţi, while the file already uses thePersonalizatwording family (e.g., Line 151). Aligning them would improve consistency.✏️ Suggested wording tweak
-STR_CUSTOMISE_STATUS_BAR: "Customizaţi bara de stare" +STR_CUSTOMISE_STATUS_BAR: "Personalizaţi bara de stare"🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@lib/I18n/translations/romanian.yaml` at line 254, The translation key STR_CUSTOMISE_STATUS_BAR uses "Customizaţi bara de stare" which is inconsistent with the established "Personalizat" wording family used elsewhere; update the value for STR_CUSTOMISE_STATUS_BAR to use the same family (e.g., "Personalizaţi bara de stare") so terminology is consistent across translations.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@lib/I18n/translations/romanian.yaml`:
- Line 254: The translation key STR_CUSTOMISE_STATUS_BAR uses "Customizaţi bara
de stare" which is inconsistent with the established "Personalizat" wording
family used elsewhere; update the value for STR_CUSTOMISE_STATUS_BAR to use the
same family (e.g., "Personalizaţi bara de stare") so terminology is consistent
across translations.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
lib/I18n/translations/romanian.yaml
📜 Review details
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2026-02-23T22:11:42.181Z
Learnt from: ariel-lindemann
Repo: crosspoint-reader/crosspoint-reader PR: 1133
File: lib/I18n/translations/finnish.yaml:92-92
Timestamp: 2026-02-23T22:11:42.181Z
Learning: In translation YAML files located in lib/I18n/translations/, literal percent signs (%) in strings (e.g., STR_HIDE_BATTERY, STR_GO_TO_PERCENT, STR_PERCENT_STEP_HINT) do not require escaping as %% and this convention is consistent across all language translations. Ensure that this pattern is followed for all YAML files in this directory to avoid introducing incorrect formatting markers in localized strings.
Applied to files:
lib/I18n/translations/romanian.yaml
🔇 Additional comments (2)
lib/I18n/translations/romanian.yaml (2)
238-239: Good addition for generic visibility actions.
STR_SHOWandSTR_HIDEare clear and fit the existing UI vocabulary.
301-301: QR label grammar fix looks correct.Line 301 now reads naturally in Romanian (
paginain definite form) and matches the intended UI text.
lukestein
approved these changes
Feb 26, 2026
Contributor
lukestein
left a comment
lukestein
left a comment
There was a problem hiding this comment.
AI reviewer feedback may or may not be an improvement (defer to native speaker):
Line 254 uses Customizaţi, while the file already uses the Personalizat wording family (e.g., Line 151). Aligning them would improve consistency.
osteotek
approved these changes
Feb 26, 2026
This was referenced Feb 26, 2026
el
pushed a commit
to el/crosspoint-reader
that referenced
this pull request
Feb 26, 2026
## Summary * **What is the goal of this PR?** (e.g., Implements the new feature for file uploading.) Romanian translations for newly added strings. * **What changes are included?** Only the translations --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**< NO >**_
iandchasse
pushed a commit
to iandchasse/crosspoint-reader-minRead
that referenced
this pull request
Feb 27, 2026
* **What is the goal of this PR?** (e.g., Implements the new feature for file uploading.) Romanian translations for newly added strings. * **What changes are included?** Only the translations --- While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**< NO >**_
This was referenced Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Romanian translations for newly added strings.
Only the translations
AI Usage
While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it
helps set the right context for reviewers.
Did you use AI tools to help write this code? < NO >