chore: Added generated lang headers to .gitignore#1158
Merged
znelson merged 1 commit intocrosspoint-reader:masterfrom Feb 24, 2026
Merged
chore: Added generated lang headers to .gitignore#1158znelson merged 1 commit intocrosspoint-reader:masterfrom
znelson merged 1 commit intocrosspoint-reader:masterfrom
Conversation
Contributor
📝 WalkthroughWalkthroughTwo generated i18n header files (lib/I18n/I18nKeys.h and lib/I18n/I18nStrings.h) are added to the .gitignore to prevent them from being tracked in version control. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ngxson
approved these changes
Feb 24, 2026
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.gitignore (1)
6-9: Consider consolidating the threelib/I18n/generated-file entries with a glob.Lines 6-8 are all generated files under the same directory. A pair of glob patterns would cover them and automatically catch any new generated headers or sources added in the future:
♻️ Optional consolidation
-lib/I18n/I18nKeys.h -lib/I18n/I18nStrings.h -lib/I18n/I18nStrings.cpp +lib/I18n/I18n*.h +lib/I18n/I18n*.cpp🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.gitignore around lines 6 - 9, Replace the three explicit generated-file entries (lib/I18n/I18nKeys.h, lib/I18n/I18nStrings.h, lib/I18n/I18nStrings.cpp) with two concise globs that cover generated headers and sources (for example use lib/I18n/*.h and lib/I18n/*.cpp) so new generated files under lib/I18n/ are automatically ignored; update the .gitignore by removing the three specific lines and adding those glob patterns referencing the lib/I18n directory.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.gitignore:
- Around line 6-9: Replace the three explicit generated-file entries
(lib/I18n/I18nKeys.h, lib/I18n/I18nStrings.h, lib/I18n/I18nStrings.cpp) with two
concise globs that cover generated headers and sources (for example use
lib/I18n/*.h and lib/I18n/*.cpp) so new generated files under lib/I18n/ are
automatically ignored; update the .gitignore by removing the three specific
lines and adding those glob patterns referencing the lib/I18n directory.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.gitignore
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: cppcheck
- GitHub Check: build
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: whyte-j
Repo: crosspoint-reader/crosspoint-reader PR: 733
File: lib/I18n/I18nKeys.h:271-272
Timestamp: 2026-02-16T22:25:35.674Z
Learning: In the crosspoint-reader i18n system (lib/I18n/), missing translation keys in non-English YAML files are automatically filled with English strings at build time by the gen_i18n.py script. All generated string arrays (STRINGS_EN, STRINGS_ES, etc.) have identical lengths, so runtime array indexing is safe without per-string fallback logic. The system prints "INFO: '{key}' missing in {lang_code}, using English fallback" during code generation when this occurs.
🔇 Additional comments (1)
.gitignore (1)
6-7: I'm ready to verify and rewrite a review comment. Please provide the review comment (within<review_comment>tags) along with any relevant code context needed for verification.
osteotek
approved these changes
Feb 24, 2026
el
pushed a commit
to el/crosspoint-reader
that referenced
this pull request
Feb 24, 2026
…1158) ## Summary **What is the goal of this PR?** Following up on crosspoint-reader#1156: generated language header files should be ignored. --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**NO**_
el
pushed a commit
to el/crosspoint-reader
that referenced
this pull request
Feb 24, 2026
…1158) ## Summary **What is the goal of this PR?** Following up on crosspoint-reader#1156: generated language header files should be ignored. --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**NO**_
el
pushed a commit
to el/crosspoint-reader
that referenced
this pull request
Feb 24, 2026
…1158) ## Summary **What is the goal of this PR?** Following up on crosspoint-reader#1156: generated language header files should be ignored. --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**NO**_
el
pushed a commit
to el/crosspoint-reader
that referenced
this pull request
Feb 24, 2026
…1158) ## Summary **What is the goal of this PR?** Following up on crosspoint-reader#1156: generated language header files should be ignored. --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**NO**_
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What is the goal of this PR?
Following up on #1156: generated language header files should be ignored.
AI Usage
While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it
helps set the right context for reviewers.
Did you use AI tools to help write this code? NO