chore: Removed generated language headers#1156
Merged
znelson merged 1 commit intocrosspoint-reader:masterfrom Feb 24, 2026
Merged
chore: Removed generated language headers#1156znelson merged 1 commit intocrosspoint-reader:masterfrom
znelson merged 1 commit intocrosspoint-reader:masterfrom
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughTwo i18n header files are removed: Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
osteotek
approved these changes
Feb 24, 2026
ngxson
approved these changes
Feb 24, 2026
Contributor
|
Btw, do we also need to add it to |
lukestein
pushed a commit
to lukestein/crosspoint-reader
that referenced
this pull request
Feb 24, 2026
## Summary **What is the goal of this PR?** I18nKeys.h and I18nStrings.h are generated by gen_i18n.py prior to each build, so we do not need to maintain a checked-in copy of these files. --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**NO**_
znelson
added a commit
that referenced
this pull request
Feb 24, 2026
## Summary **What is the goal of this PR?** Following up on #1156: generated language header files should be ignored. --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**NO**_
el
pushed a commit
to el/crosspoint-reader
that referenced
this pull request
Feb 24, 2026
**What is the goal of this PR?** I18nKeys.h and I18nStrings.h are generated by gen_i18n.py prior to each build, so we do not need to maintain a checked-in copy of these files. --- While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**NO**_
el
pushed a commit
to el/crosspoint-reader
that referenced
this pull request
Feb 24, 2026
…1158) ## Summary **What is the goal of this PR?** Following up on crosspoint-reader#1156: generated language header files should be ignored. --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**NO**_
el
pushed a commit
to el/crosspoint-reader
that referenced
this pull request
Feb 24, 2026
**What is the goal of this PR?** I18nKeys.h and I18nStrings.h are generated by gen_i18n.py prior to each build, so we do not need to maintain a checked-in copy of these files. --- While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**NO**_
el
pushed a commit
to el/crosspoint-reader
that referenced
this pull request
Feb 24, 2026
…1158) ## Summary **What is the goal of this PR?** Following up on crosspoint-reader#1156: generated language header files should be ignored. --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**NO**_
el
pushed a commit
to el/crosspoint-reader
that referenced
this pull request
Feb 24, 2026
**What is the goal of this PR?** I18nKeys.h and I18nStrings.h are generated by gen_i18n.py prior to each build, so we do not need to maintain a checked-in copy of these files. --- While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**NO**_
el
pushed a commit
to el/crosspoint-reader
that referenced
this pull request
Feb 24, 2026
…1158) ## Summary **What is the goal of this PR?** Following up on crosspoint-reader#1156: generated language header files should be ignored. --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**NO**_
el
pushed a commit
to el/crosspoint-reader
that referenced
this pull request
Feb 24, 2026
**What is the goal of this PR?** I18nKeys.h and I18nStrings.h are generated by gen_i18n.py prior to each build, so we do not need to maintain a checked-in copy of these files. --- While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**NO**_
el
pushed a commit
to el/crosspoint-reader
that referenced
this pull request
Feb 24, 2026
…1158) ## Summary **What is the goal of this PR?** Following up on crosspoint-reader#1156: generated language header files should be ignored. --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**NO**_
This was referenced Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What is the goal of this PR?
I18nKeys.h and I18nStrings.h are generated by gen_i18n.py prior to each build, so we do not need to maintain a checked-in copy of these files.
AI Usage
While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it
helps set the right context for reviewers.
Did you use AI tools to help write this code? NO