feat: Add Polish Language by th0m4sek · Pull Request #1155 · crosspoint-reader/crosspoint-reader

th0m4sek · 2026-02-24T16:19:25Z

Summary

What is the goal of this PR? Implements Polish language
What changes are included?

Additional Context

Add any other information that might be helpful for the reviewer (e.g., performance implications, potential risks,
specific areas to focus on).

AI Usage

While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it
helps set the right context for reviewers.

Did you use AI tools to help write this code? < YES | PARTIALLY | NO >

coderabbitai · 2026-02-24T16:20:04Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

📝 Walkthrough

Walkthrough

Removes the i18n public header/API declarations (lib/I18n/I18nKeys.h, lib/I18n/I18nStrings.h) and adds a new Polish translation resource (lib/I18n/translations/polish.yaml). Also updates scripts/gen_i18n.py to map "polish" → "PL".

Changes

Cohort / File(s)	Summary
I18n public headers removed `lib/I18n/I18nKeys.h`, `lib/I18n/I18nStrings.h`	Deleted the generated public i18n header declarations: all `STRINGS_*` extern arrays, `Language` and `StrId` enums, `LANGUAGE_NAMES`, `CHARACTER_SETS`, and helper functions (e.g., `getStringArray`, `getLanguageCount`).
Translation resource added `lib/I18n/translations/polish.yaml`	Added Polish localization YAML (+~320 lines) with `_language_` metadata and many `STR_` keys containing Polish strings.
Generation script `scripts/gen_i18n.py`	Added/updated language-abbreviation mapping to include `"polish" → "PL"`.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

chore: Removed generated language headers #1156: Also removes the generated i18n public headers (same files affected).
feat: Add full Italian translations #1144: Adds/removes Italian i18n symbols (overlaps on STRINGS_IT / Language enum names).
feat: add Catalan strings #1049: Adds Catalan support by modifying the same i18n header-level declarations and translation resources.

Suggested reviewers

osteotek
ngxson

🚥 Pre-merge checks | ✅ 1 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	The description states the goal (implementing Polish language) but lacks substantive detail about what changes are included, leaving it vague and generic.	Expand the description to explain the changes made: adding polish.yaml translation file, updating gen_i18n.py with Polish abbreviation mapping, and removing i18n header files that appear to be regenerated.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'feat: Add Polish Language' directly and accurately describes the main change—implementing Polish language support as confirmed by the summary of changes.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🧹 Nitpick comments (1)

lib/I18n/translations/polish.yaml (1)
60-130: Confirm remaining English strings are intentional.
Several entries remain in English (e.g., STR_CONNECT_WIRELESS, STR_STATUS_BAR, STR_EXTRA_SPACING, STR_COLOR_MODE, STR_DOCUMENT_MATCHING, STR_EXTERNAL_FONT, STR_FETCH_FEED_FAILED, STR_UI_THEME, STR_CALIBRE_DESC, STR_GO_HOME_BUTTON, STR_SYNC_PROGRESS). If this is not intentional, consider translating them for a consistent Polish UI.

Also applies to: 159-319
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@lib/I18n/translations/polish.yaml` around lines 60 - 130, Several translation
keys (e.g., STR_CONNECT_WIRELESS, STR_STATUS_BAR, STR_EXTRA_SPACING,
STR_COLOR_MODE, STR_DOCUMENT_MATCHING,
STR_EXT_READER_FONT/STR_EXT_CHINESE_FONT/STR_EXT_UI_FONT, STR_FETCH_FEED_FAILED,
STR_UI_THEME, STR_CALIBRE_DESC, STR_GO_HOME_BUTTON, STR_SYNC_PROGRESS) are still
in English; please provide Polish translations for these entries to ensure a
consistent UI. Locate the keys in the polish.yaml (present around the shown
block and later between lines ~159-319) and replace the English values with
their correct Polish equivalents, keeping the same key names and
escaping/formatting (e.g., newline sequences) as in existing entries; if any
keys are intentionally left English, add a comment beside them indicating that’s
deliberate. Ensure pluralization/grammar fits the app context (labels vs.
sentences) and run a quick pass to verify no other English strings remain in the
file.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@lib/I18n/translations/polish.yaml`:
- Line 15: The STR_START_READING translation contains Polish typos/incorrect
diacritics ("Zacznij czytać póniźej") — update its value to the correct Polish
string (e.g., "Zacznij czytać poniżej"); then scan the Polish YAML for other
user-facing strings flagged in the review and correct their spelling/diacritics
as well, ensuring keys like STR_START_READING and the other flagged translation
keys have natural, grammatically correct Polish text.

---

Nitpick comments:
In `@lib/I18n/translations/polish.yaml`:
- Around line 60-130: Several translation keys (e.g., STR_CONNECT_WIRELESS,
STR_STATUS_BAR, STR_EXTRA_SPACING, STR_COLOR_MODE, STR_DOCUMENT_MATCHING,
STR_EXT_READER_FONT/STR_EXT_CHINESE_FONT/STR_EXT_UI_FONT, STR_FETCH_FEED_FAILED,
STR_UI_THEME, STR_CALIBRE_DESC, STR_GO_HOME_BUTTON, STR_SYNC_PROGRESS) are still
in English; please provide Polish translations for these entries to ensure a
consistent UI. Locate the keys in the polish.yaml (present around the shown
block and later between lines ~159-319) and replace the English values with
their correct Polish equivalents, keeping the same key names and
escaping/formatting (e.g., newline sequences) as in existing entries; if any
keys are intentionally left English, add a comment beside them indicating that’s
deliberate. Ensure pluralization/grammar fits the app context (labels vs.
sentences) and run a quick pass to verify no other English strings remain in the
file.

ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d6d0cc8 and 9c646df.

📒 Files selected for processing (3)

lib/I18n/I18nKeys.h
lib/I18n/I18nStrings.h
lib/I18n/translations/polish.yaml

📜 Review details

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

GitHub Check: cppcheck
GitHub Check: build

🧰 Additional context used

🧠 Learnings (2)

📚 Learning: 2026-02-16T22:25:35.674Z

Learnt from: whyte-j
Repo: crosspoint-reader/crosspoint-reader PR: 733
File: lib/I18n/I18nKeys.h:271-272
Timestamp: 2026-02-16T22:25:35.674Z
Learning: In the crosspoint-reader i18n system (lib/I18n/), missing translation keys in non-English YAML files are automatically filled with English strings at build time by the gen_i18n.py script. All generated string arrays (STRINGS_EN, STRINGS_ES, etc.) have identical lengths, so runtime array indexing is safe without per-string fallback logic. The system prints "INFO: '{key}' missing in {lang_code}, using English fallback" during code generation when this occurs.

Applied to files:

lib/I18n/I18nStrings.h
lib/I18n/translations/polish.yaml
lib/I18n/I18nKeys.h

📚 Learning: 2026-02-23T22:11:42.181Z

Learnt from: ariel-lindemann
Repo: crosspoint-reader/crosspoint-reader PR: 1133
File: lib/I18n/translations/finnish.yaml:92-92
Timestamp: 2026-02-23T22:11:42.181Z
Learning: In translation YAML files located in lib/I18n/translations/, literal percent signs (%) in strings (e.g., STR_HIDE_BATTERY, STR_GO_TO_PERCENT, STR_PERCENT_STEP_HINT) do not require escaping as %% and this convention is consistent across all language translations. Ensure that this pattern is followed for all YAML files in this directory to avoid introducing incorrect formatting markers in localized strings.

Applied to files:

lib/I18n/translations/polish.yaml

🧬 Code graph analysis (1)

lib/I18n/I18nKeys.h (1)

lib/I18n/I18nStrings.h (1)

i18n_strings (8-25)

🔇 Additional comments (4)

lib/I18n/I18nStrings.h (1)

23-23: LGTM — Polish strings export is wired.

lib/I18n/I18nKeys.h (3)

21-21: LGTM — STRINGS_PL forward declaration added.

39-40: LGTM — enum extended with POLISH.

400-401: LGTM — switch now maps POLISH to STRINGS_PL.

coderabbitai · 2026-02-24T16:23:52Z

lib/I18n/translations/polish.yaml

+STR_CALIBRE_LIBRARY: "Biblioteka Calibre"
+STR_CONTINUE_READING: "Wznów czytanie"
+STR_NO_OPEN_BOOK: "Brak otwartych książek"
+STR_START_READING: "Zacznij czytać póniźej"


⚠️ Potential issue | 🟡 Minor

Fix Polish typos/diacritics in user-facing strings.
These look like spelling/grammar errors in the UI.

✏️ Suggested corrections

-STR_START_READING: "Zacznij czytać póniźej" +STR_START_READING: "Zacznij czytać poniżej" -STR_CHECK_UPDATES: "Sprawdź uaktualnia" +STR_CHECK_UPDATES: "Sprawdź aktualizacje" -STR_CLEAR_CACHE_WARNING_1: "To wyczyści całą pamięc podręczną książek." +STR_CLEAR_CACHE_WARNING_1: "To wyczyści całą pamięć podręczną książek." -STR_CHECK_SERIAL_OUTPUT: "Szczególy sprawdź na wyjściu szeregowym" +STR_CHECK_SERIAL_OUTPUT: "Szczegóły sprawdź na wyjściu szeregowym" -STR_SCAN_QR_WIFI_HINT: "albo skanuj kod QRtelefonem aby połączyć sie do Wifi." +STR_SCAN_QR_WIFI_HINT: "albo skanuj kod QR telefonem, aby połączyć się do WiFi." -STR_REMAP_PROMPT: "Przyciśnij przednij przycisk dla każdej funkcji" +STR_REMAP_PROMPT: "Przyciśnij przedni przycisk dla każdej funkcji"

Also applies to: 117-117, 139-139, 148-148, 219-219, 275-275

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed. In `@lib/I18n/translations/polish.yaml` at line 15, The STR_START_READING translation contains Polish typos/incorrect diacritics ("Zacznij czytać póniźej") — update its value to the correct Polish string (e.g., "Zacznij czytać poniżej"); then scan the Polish YAML for other user-facing strings flagged in the review and correct their spelling/diacritics as well, ensuring keys like STR_START_READING and the other flagged translation keys have natural, grammatically correct Polish text.

znelson

I think you need to update gen_i18n.py: both Polish and Portuguese are getting the "PO" language code. Can you add "polski": "PL", to the LANG_ABBREVIATIONS map?

Additionally, I think we've been mistaken by maintaining checked-in copies of I18nKeys.h and I18nStrings.h. Those get generated automatically at build time. I believe you can delete those.

znelson

Looks good to me! We can also delete I18nKeys.h and I18nStrings.h in a separate change.

coderabbitai

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

scripts/gen_i18n.py (1)
208-216: ⚠️ Potential issue | 🔴 Critical

Add native Polish language name to LANG_ABBREVIATIONS to prevent symbol mismatch.

The _language_name in polish.yaml is "Polski" (native name), which lowercases to "polski". The current LANG_ABBREVIATIONS dict only has "polish": "PL" but not "polski": "PL". When get_lang_abbreviation() is called with lang_name="Polski", it will fail to match and fall back to lang_code[:2].upper(), which produces "PO" from "POLISH". This causes the build to generate STRINGS_PO instead of the expected STRINGS_PL, creating a symbol mismatch since STRINGS_PL is already declared in lib/I18n/I18nStrings.h and referenced in lib/I18n/I18nKeys.h.

Add the native name mapping:
Suggested fix
 LANG_ABBREVIATIONS = {
     "english": "EN",
     "español": "ES", "espanol": "ES",
     "italiano": "IT",
     "svenska": "SV",
     "français": "FR", "francais": "FR",
     "deutsch": "DE", "german": "DE",
-    "polish": "PL",
+    "polish": "PL", "polski": "PL",
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@scripts/gen_i18n.py` around lines 208 - 216, The LANG_ABBREVIATIONS mapping
is missing the Polish native name so get_lang_abbreviation() can miscompute the
abbrev; add an entry mapping "polski" to "PL" in the LANG_ABBREVIATIONS dict
(alongside the existing "polish": "PL") so lookups of lowercased _language_name
produce "PL" instead of falling back to lang_code[:2].upper() and generating
"PO".

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@scripts/gen_i18n.py`:
- Around line 208-216: The LANG_ABBREVIATIONS mapping is missing the Polish
native name so get_lang_abbreviation() can miscompute the abbrev; add an entry
mapping "polski" to "PL" in the LANG_ABBREVIATIONS dict (alongside the existing
"polish": "PL") so lookups of lowercased _language_name produce "PL" instead of
falling back to lang_code[:2].upper() and generating "PO".

ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 25f331b and c62eaba.

📒 Files selected for processing (1)

scripts/gen_i18n.py

📜 Review details

🧰 Additional context used

🧠 Learnings (2)

📓 Common learnings

Learnt from: whyte-j
Repo: crosspoint-reader/crosspoint-reader PR: 733
File: lib/I18n/I18nKeys.h:271-272
Timestamp: 2026-02-16T22:25:35.674Z
Learning: In the crosspoint-reader i18n system (lib/I18n/), missing translation keys in non-English YAML files are automatically filled with English strings at build time by the gen_i18n.py script. All generated string arrays (STRINGS_EN, STRINGS_ES, etc.) have identical lengths, so runtime array indexing is safe without per-string fallback logic. The system prints "INFO: '{key}' missing in {lang_code}, using English fallback" during code generation when this occurs.

📚 Learning: 2026-02-23T19:55:03.054Z

Learnt from: martinbrook
Repo: crosspoint-reader/crosspoint-reader PR: 1136
File: scripts/patch_jpegdec.py:20-23
Timestamp: 2026-02-23T19:55:03.054Z
Learning: In the crosspoint-reader project, enable Python linters (e.g., Ruff or Flake8) in CI for all Python scripts. Run linting as part of the CI workflow and fix reported issues to maintain code quality. Do not skip linting for any Python files.

Applied to files:

scripts/gen_i18n.py

osteotek · 2026-02-24T22:06:52Z

lib/I18n/translations/polish.yaml

+STR_GO_HOME_BUTTON: "Go Home"
+STR_SYNC_PROGRESS: "Sync Progress"
+STR_DELETE_CACHE: "Delete Book Cache"


not every string is translated?

with new status bar settings

add missing tranlations

lib/I18n/translations/polish.yaml

## Summary * **What is the goal of this PR?** Implements Polish language * **What changes are included?** ## Additional Context * Add any other information that might be helpful for the reviewer (e.g., performance implications, potential risks, specific areas to focus on). --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**< YES | PARTIALLY | NO >**_ --------- Co-authored-by: Zach Nelson <[email protected]> Co-authored-by: Arthur Tazhitdinov <[email protected]>

th0m4sek added 3 commits February 24, 2026 17:15

Add files via upload

44bc619

Update I18nStrings.h

5fa22cb

Update I18nKeys.h

9c646df

znelson changed the title ~~Feat: Add Polish Language~~ feat: Add Polish Language Feb 24, 2026

coderabbitai bot reviewed Feb 24, 2026

View reviewed changes

Update polish.yaml

25f331b

znelson reviewed Feb 24, 2026

View reviewed changes

Update gen_i18n.py

c62eaba

znelson previously approved these changes Feb 24, 2026

View reviewed changes

znelson requested a review from osteotek February 24, 2026 17:11

coderabbitai bot reviewed Feb 24, 2026

View reviewed changes

Update gen_i18n.py

27442d3

znelson dismissed their stale review via 27442d3 February 24, 2026 17:14

znelson previously approved these changes Feb 24, 2026

View reviewed changes

Delete lib/I18n/I18nKeys.h

857f2fe

znelson dismissed their stale review via 857f2fe February 24, 2026 17:45

Delete lib/I18n/I18nStrings.h

4d051af

znelson previously approved these changes Feb 24, 2026

View reviewed changes

osteotek reviewed Feb 24, 2026

View reviewed changes

th0m4sek added 2 commits February 25, 2026 14:33

Merge branch 'crosspoint-reader:master' into master

19898a5

Update polish.yaml

3bb6257

with new status bar settings

th0m4sek dismissed znelson’s stale review via 3bb6257 February 25, 2026 13:44

th0m4sek added 2 commits February 25, 2026 16:32

Merge branch 'crosspoint-reader:master' into master

ed53f79

Update polish.yaml

50a08e1

add missing tranlations

osteotek previously approved these changes Feb 25, 2026

View reviewed changes

osteotek reviewed Feb 25, 2026

View reviewed changes

lib/I18n/translations/polish.yaml Outdated Show resolved Hide resolved

osteotek dismissed their stale review via 9f8149b February 25, 2026 16:56

Apply suggestion from @osteotek

9f8149b

osteotek approved these changes Feb 25, 2026

View reviewed changes

znelson approved these changes Feb 25, 2026

View reviewed changes

znelson enabled auto-merge (squash) February 25, 2026 17:00

znelson merged commit cae8517 into crosspoint-reader:master Feb 25, 2026
6 checks passed

coderabbitai bot mentioned this pull request Feb 26, 2026

feat: Polish translation tweaks #1193

Merged

This was referenced Feb 28, 2026

feat: Add Polish strings for commits #1219,#1169,#1031 +tweaks #1227

Merged

chore: Image settings Polish localization #1299

Open

Uh oh!

Conversation

th0m4sek commented Feb 24, 2026

Summary

Additional Context

AI Usage

Uh oh!

coderabbitai bot commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

❌ Failed checks (1 inconclusive)

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

znelson left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

znelson left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

osteotek Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

th0m4sek Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai bot commented Feb 24, 2026 •

edited

Loading

znelson left a comment •

edited

Loading