src/components/themes/BaseTheme.cpp (1)

513-514: Author truncation is performed twice with identical parameters.

truncatedText(UI_10_FONT_ID, lastBookAuthor.c_str(), bookWidth - 40) is called at Line 513 (for box width calculation inside if (coverRendered)) and again at Line 538 (for rendering). Since both use identical parameters, consider hoisting the result above the if (coverRendered) block to avoid redundant text measurement.

Proposed refactor

+    std::string truncatedAuthor;
+    int authorWidth = 0;
+    if (!lastBookAuthor.empty()) {
+      truncatedAuthor = renderer.truncatedText(UI_10_FONT_ID, lastBookAuthor.c_str(), bookWidth - 40);
+      authorWidth = renderer.getTextWidth(UI_10_FONT_ID, truncatedAuthor.c_str());
+    }
+
     // If cover image was rendered, draw box behind title and author
     if (coverRendered) {
       constexpr int boxPadding = 8;
       // Calculate the max text width for the box
       int maxTextWidth = 0;
       for (const auto& line : lines) {
         const int lineWidth = renderer.getTextWidth(UI_12_FONT_ID, line.c_str());
         if (lineWidth > maxTextWidth) {
           maxTextWidth = lineWidth;
         }
       }
       if (!lastBookAuthor.empty()) {
-        const auto truncatedAuthor = renderer.truncatedText(UI_10_FONT_ID, lastBookAuthor.c_str(), bookWidth - 40);
-        const int authorWidth = renderer.getTextWidth(UI_10_FONT_ID, truncatedAuthor.c_str());
         if (authorWidth > maxTextWidth) {
           maxTextWidth = authorWidth;
         }
       }
       ...
     }
     ...
     if (!lastBookAuthor.empty()) {
       titleYStart += renderer.getLineHeight(UI_10_FONT_ID) / 2;
-      auto trimmedAuthor = renderer.truncatedText(UI_10_FONT_ID, lastBookAuthor.c_str(), bookWidth - 40);
-      renderer.drawCenteredText(UI_10_FONT_ID, titleYStart, trimmedAuthor.c_str(), !bookSelected);
+      renderer.drawCenteredText(UI_10_FONT_ID, titleYStart, truncatedAuthor.c_str(), !bookSelected);
     }

Also applies to: 538-538

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/components/themes/BaseTheme.cpp` around lines 513 - 514, Hoist the
duplicated author truncation by computing truncatedAuthor once before the
coverRendered check and reuse it in both measurement and rendering: call
renderer.truncatedText(UI_10_FONT_ID, lastBookAuthor.c_str(), bookWidth - 40)
once into a local variable (e.g., truncatedAuthor) above the if (coverRendered)
block, then use that same truncatedAuthor for authorWidth via
renderer.getTextWidth(UI_10_FONT_ID, truncatedAuthor.c_str()) and later when
rendering; update references to avoid calling renderer.truncatedText a second
time.

lib/GfxRenderer/GfxRenderer.cpp (1)

855-893: Prefer static_cast<int> over C-style casts.

Lines 856 and 892 use (int)lines.size(). The rest of this PR (e.g., Lyra3CoversTheme.cpp Line 96, BaseTheme.cpp Line 493) consistently uses static_cast<int>(...). Consider aligning for consistency.

Proposed fix

-    if ((int)lines.size() == maxLines - 1) {
+    if (static_cast<int>(lines.size()) == maxLines - 1) {

-  if (!currentLine.empty() && (int)lines.size() < maxLines) {
+  if (!currentLine.empty() && static_cast<int>(lines.size()) < maxLines) {

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@lib/GfxRenderer/GfxRenderer.cpp` around lines 855 - 893, Replace the two
C-style casts of (int)lines.size() in GfxRenderer.cpp with C++-style casts:
where the loop checks if ((int)lines.size() == maxLines - 1) and where the final
if uses (int)lines.size(), change them to static_cast<int>(lines.size()) so the
comparisons use static_cast<int>(lines.size()) == maxLines - 1 and
static_cast<int>(lines.size()) < maxLines respectively; update both occurrences
to match the project's casting style.

src/components/themes/lyra/Lyra3CoversTheme.cpp (1)

26-26: Remove unused bookTitleHeight variable.

bookTitleHeight is computed on line 26 but never referenced. The title-box rendering uses dynamicTitleBoxHeight (line 109) instead. Remove the dead code.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/components/themes/lyra/Lyra3CoversTheme.cpp` at line 26, Remove the dead
local variable bookTitleHeight declared in Lyra3CoversTheme.cpp (the const int
bookTitleHeight = ... line); it is never referenced (rendering uses
dynamicTitleBoxHeight), so delete that declaration and any related unused
hPaddingInSelection-only computation tied solely to bookTitleHeight to avoid
unused-variable warnings; ensure no other code paths reference bookTitleHeight
before committing.

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

lib/GfxRenderer/GfxRenderer.cpp (1)

881-883: ⚠️ Potential issue | 🟠 Major

Oversized word assigned to currentLine without truncation — line overflow still possible.

When currentLine is non-empty and the combined testLine exceeds maxWidth, the existing line is flushed and word becomes the new currentLine. However, if word alone is wider than maxWidth it will later be pushed untruncated — either when the next word also overflows (triggering another flush) or at the final push (Line 894–896). Only the currentLine.empty() branch (Line 884–890) and the last-line branch (Line 856–862) truncate an oversized word.

Example with maxLines = 3, maxWidth = 100, words ["Hi", "Superlongword", "End"] where "Superlongword" alone > 100 px:

1. "Hi" fits → currentLine = "Hi"
2. "Hi Superlongword" overflows → push "Hi", currentLine = "Superlongword" (untruncated!)
3. "Superlongword End" overflows → push "Superlongword" (exceeds maxWidth!)
4. Loop ends, push "End"

Result: ["Hi", "Superlongword", "End"] — line 2 overflows the render box.

🐛 Proposed fix

       if (!currentLine.empty()) {
         lines.push_back(currentLine);
-        currentLine = word;
+        if (getTextWidth(fontId, word.c_str(), style) > maxWidth) {
+          lines.push_back(truncatedText(fontId, word.c_str(), maxWidth, style));
+          currentLine.clear();
+        } else {
+          currentLine = word;
+        }
       } else {

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@lib/GfxRenderer/GfxRenderer.cpp` around lines 881 - 883, When flushing a
non-empty currentLine because testLine exceeds maxWidth, ensure the new
assignment currentLine = word also truncates oversized words: check the pixel
width of word against maxWidth and, if it exceeds, replace word with the same
truncation routine used elsewhere (the code path in the currentLine.empty()
branch and the final-line branch) before assigning to currentLine; update the
logic around testLine/currentLine/word to call that truncate helper (or inline
truncateToWidth behavior) so no single word pushed into lines can exceed
maxWidth.

lib/GfxRenderer/GfxRenderer.cpp (1)

856-856: Nitpick: prefer static_cast<int> over C-style cast.

(int)lines.size() is used at lines 856 and 894. Prefer static_cast<int>(lines.size()) for consistency with the rest of the codebase.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@lib/GfxRenderer/GfxRenderer.cpp` at line 856, Replace the C-style casts of
lines.size() with C++ style casts: change occurrences of (int)lines.size()
(notably where used in the conditional around maxLines — currently at the checks
near lines 856 and 894 in GfxRenderer.cpp) to static_cast<int>(lines.size());
update both sites so the codebase uses static_cast consistently.

wrapped-text-refactor.patch (1)

304-310: homeCoverTileHeight bump to 300 is tied to the font metric constraint noted above.

If SMALL_FONT_ID's advanceY > 17 px the tile will still be too short for 3-line titles. Consider deriving this constant programmatically (e.g. homeCoverHeight + 2 * hPaddingInSelection + 5 + 3 * lineHeight) or at minimum add a comment documenting the font-size dependency.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@wrapped-text-refactor.patch` around lines 304 - 310, The hardcoded bump of
ThemeMetrics.homeCoverTileHeight to 300 depends on the SMALL_FONT_ID font metric
(advanceY) and can still be too short if SMALL_FONT_ID.advanceY > 17; update the
value to be derived programmatically (e.g. compute homeCoverTileHeight from
homeCoverHeight plus padding and 3*lineHeight using the SMALL_FONT_ID.advanceY)
or, if you keep a constant, add a clear comment next to
ThemeMetrics.homeCoverTileHeight explaining the dependency on
SMALL_FONT_ID.advanceY and why 300 was chosen; reference
ThemeMetrics.homeCoverTileHeight, SMALL_FONT_ID, SMALL_FONT_ID.advanceY,
homeCoverHeight and any hPaddingInSelection/lineHeight helpers in the
implementation so the relationship is obvious and robust to font changes.

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro