Skip to content

fix: add missing keyboard metrics to Lyra3CoversTheme#1101

Merged
lukestein merged 1 commit intocrosspoint-reader:masterfrom
dexif:fix/lyra3-keyboard-metrics
Feb 23, 2026
Merged

fix: add missing keyboard metrics to Lyra3CoversTheme#1101
lukestein merged 1 commit intocrosspoint-reader:masterfrom
dexif:fix/lyra3-keyboard-metrics

Conversation

@dexif
Copy link
Contributor

@dexif dexif commented Feb 22, 2026

Fix for keyboard. Issue #1100

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 22, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 63002d4 and e8e27a6.

📒 Files selected for processing (1)
  • src/components/themes/lyra/Lyra3CoversTheme.h
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build
  • GitHub Check: cppcheck
🔇 Additional comments (1)
src/components/themes/lyra/Lyra3CoversTheme.h (1)

33-38: Verify that keyboard metric fields exist in ThemeMetrics struct definition.

The new keyboard configuration values look reasonable for theme metrics, and the designated initializer syntax is correct. However, these fields must be properly defined in the ThemeMetrics struct for this code to compile. Confirm that keyboardKeyWidth, keyboardKeyHeight, keyboardKeySpacing, keyboardBottomAligned, and keyboardCenteredText are declared in the struct definition.

📝 Walkthrough

Walkthrough

Adds keyboard-related layout metrics to the Lyra3CoversTheme configuration, introducing five new metric fields: keyboardKeyWidth, keyboardKeyHeight, keyboardKeySpacing, keyboardBottomAligned, and keyboardCenteredText with their respective values and defaults.

Changes

Cohort / File(s) Summary
Keyboard Layout Metrics
src/components/themes/lyra/Lyra3CoversTheme.h		 Adds five keyboard-related metric fields (keyboardKeyWidth, keyboardKeyHeight, keyboardKeySpacing, keyboardBottomAligned, keyboardCenteredText) to the Lyra3CoversMetrics configuration values.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • daveallie
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding missing keyboard metrics to Lyra3CoversTheme, which aligns with the changeset.
Description check ✅ Passed The description references Issue #1100 and mentions it is a fix for keyboard, which relates to the keyboard metrics being added in the changeset.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.

Comment @coderabbitai help to get the list of available commands and usage tips.

lukestein
lukestein approved these changes Feb 23, 2026
View reviewed changes
Copy link
Contributor

@lukestein lukestein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully on device. Thank you!

@daveallie, this fixes #1100 which could arguably have been a blocking issue. You might consider a 1.1.1 with this fix.

@lukestein lukestein merged commit 6dc9938 into crosspoint-reader:master Feb 23, 2026
7 checks passed
@lukestein lukestein mentioned this pull request Feb 23, 2026
Closed
daveallie pushed a commit that referenced this pull request Feb 23, 2026
@dexif @daveallie
fix: add missing keyboard metrics to Lyra3CoversTheme (#1101)
ebe3123 
Fix for keyboard. Issue #1100
@daveallie
Copy link
Member

daveallie commented Feb 23, 2026

Thanks for this, I released in v1.1.1

@dexif dexif deleted the fix/lyra3-keyboard-metrics branch February 23, 2026 07:31
lukestein pushed a commit to lukestein/crosspoint-reader that referenced this pull request Feb 23, 2026
@dexif @lukestein
fix: add missing keyboard metrics to Lyra3CoversTheme (crosspoint-rea…
c1ae5ed 
…der#1101)

Fix for keyboard. Issue crosspoint-reader#1100
el pushed a commit to el/crosspoint-reader that referenced this pull request Feb 24, 2026
@dexif @el
fix: add missing keyboard metrics to Lyra3CoversTheme (crosspoint-rea…
d61419f 
…der#1101)

Fix for keyboard. Issue crosspoint-reader#1100
el pushed a commit to el/crosspoint-reader that referenced this pull request Feb 24, 2026
@dexif
fix: add missing keyboard metrics to Lyra3CoversTheme (crosspoint-rea…
dd408bf 
…der#1101)

Fix for keyboard. Issue crosspoint-reader#1100
@coderabbitai coderabbitai bot mentioned this pull request Feb 26, 2026
Open
@laird laird mentioned this pull request Mar 1, 2026
Closed
9 tasks
laird pushed a commit to laird/crosspoint-claw that referenced this pull request Mar 1, 2026
@dexif @laird
fix: add missing keyboard metrics to Lyra3CoversTheme (crosspoint-rea…
b789677 
…der#1101)

Fix for keyboard. Issue crosspoint-reader#1100
laird added a commit to laird/crosspoint-claw that referenced this pull request Mar 1, 2026
@laird
merge: integrate rescue-1.0.0 cherry-picks into feature/rss-feed-sync
7a54234 
Cherry-picked upstream fixes and features applied via rescue-1.0.0 worktree:
- fix: properly implement requestUpdateAndWait() (crosspoint-reader#1218)
- fix: Hide unusable button hints in empty directory (crosspoint-reader#1253)
- fix: add missing keyboard metrics to Lyra3CoversTheme (crosspoint-reader#1101)
- fix: remove bookProgressBarHeight from Lyra3CoversTheme
- feat: replace picojpeg with JPEGDEC for JPEG decoding (crosspoint-reader#1136)
- feat: WIFI pill, feed log fix, JPEGDEC version string
- feat: Add git branch to version string (crosspoint-reader#1225)
- fix: navigate directly to QR code after DZ auto-connect
- perf: Removed unused ConfirmationActivity member (crosspoint-reader#1234)
- refactor: Simplify new setting introduction (crosspoint-reader#1086)
- fix: UI fonts, settings stack overflow, PULSR theme name
- fix: convert SettingsList to push_back (prevent stack overflow)

All commits built and verified on device (confirmed 1.1.0-dev+d1e786a).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@znelson znelson znelson approved these changes

@lukestein lukestein lukestein approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dexif @daveallie @znelson @lukestein