Skip to content

chore: Resolve several build warnings#1076

Merged
daveallie merged 1 commit intomasterfrom
fix/build-warnings
Feb 22, 2026
Merged

chore: Resolve several build warnings#1076
daveallie merged 1 commit intomasterfrom
fix/build-warnings

Conversation

@daveallie
Copy link
Member

@daveallie daveallie commented Feb 22, 2026

Summary

  • Resolve several build warnings

AI Usage

While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it
helps set the right context for reviewers.

Did you use AI tools to help write this code? No

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 22, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a610568 and d1f64b0.

📒 Files selected for processing (2)
  • lib/Logging/Logging.h
  • platformio.ini
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build
  • GitHub Check: cppcheck
🔇 Additional comments (2)
platformio.ini (1)

38-38: The -Wno-bidi-chars flag addition is justified. The repository contains legitimate bidi control characters in font data files (lib/EpdFont/builtinFonts/*.h) and internationalization support (lib/Epub/Epub/htmlEntities.cpp). These are not Trojan Source risks—they are intentional use cases for text rendering and language support. Removing the flag or scoping it per-file would generate spurious warnings without security benefit and introduce impractical maintenance overhead across 49+ font files.

Likely an incorrect or invalid review comment.

lib/Logging/Logging.h (1)

71-74: No action needed—the macro guard placement is already correct.

The current structure at lines 71-74 is optimal. When this header is included, Serial from HardwareSerial.h is already a macro, and expanding it at line 28 correctly binds logSerial to the real hardware serial object. Only after this binding is complete should Serial be redefined to MySerialImpl::instance at lines 71-74, which is exactly where it is now. Moving the #undef before line 28 would leave Serial undefined when needed, breaking the initialization.

Likely an incorrect or invalid review comment.

📝 Walkthrough

Walkthrough

This pull request modifies two files to address macro definition safety and compiler warnings. The logging header introduces a guard-then-undef sequence to safely redefine the Serial macro, preventing redefinition conflicts. The build configuration adds a compiler flag to suppress bidi character warnings.

Changes

Cohort / File(s) Summary
Logging Macro Handling
lib/Logging/Logging.h		 Adds guard-then-undef sequence to safely redefine Serial macro to MySerialImpl::instance, preventing macro redefinition conflicts.
Compiler Configuration
platformio.ini		 Adds -Wno-bidi-chars compiler flag to suppress bidi character warnings; removes trailing blank line.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The PR title accurately describes the main objective of the changeset: resolving multiple build warnings by modifying logging headers and compiler flags.
Description check ✅ Passed The PR description is directly related to the changeset, stating the objective to resolve several build warnings, which matches the changes made.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Comment @coderabbitai help to get the list of available commands and usage tips.

@daveallie daveallie merged commit f28623d into master Feb 22, 2026
7 checks passed
@daveallie daveallie deleted the fix/build-warnings branch February 22, 2026 09:56
lukestein pushed a commit to lukestein/crosspoint-reader that referenced this pull request Feb 22, 2026
@daveallie @lukestein
chore: Resolve several build warnings (crosspoint-reader#1076)
86c3d0d 
## Summary

* Resolve several build warnings

---

### AI Usage

While CrossPoint doesn't have restrictions on AI tools in contributing,
please be transparent about their usage as it
helps set the right context for reviewers.

Did you use AI tools to help write this code? No
lukestein pushed a commit to lukestein/crosspoint-reader that referenced this pull request Feb 22, 2026
@daveallie @lukestein
chore: Resolve several build warnings (crosspoint-reader#1076)
ccd54e1 
## Summary

* Resolve several build warnings

---

### AI Usage

While CrossPoint doesn't have restrictions on AI tools in contributing,
please be transparent about their usage as it
helps set the right context for reviewers.

Did you use AI tools to help write this code? No
lukestein pushed a commit to lukestein/crosspoint-reader that referenced this pull request Feb 22, 2026
@daveallie @lukestein
chore: Resolve several build warnings (crosspoint-reader#1076)
e42516f 
## Summary

* Resolve several build warnings

---

### AI Usage

While CrossPoint doesn't have restrictions on AI tools in contributing,
please be transparent about their usage as it
helps set the right context for reviewers.

Did you use AI tools to help write this code? No
lukestein pushed a commit to lukestein/crosspoint-reader that referenced this pull request Feb 22, 2026
@daveallie @lukestein
chore: Resolve several build warnings (crosspoint-reader#1076)
320063b 
## Summary

* Resolve several build warnings

---

### AI Usage

While CrossPoint doesn't have restrictions on AI tools in contributing,
please be transparent about their usage as it
helps set the right context for reviewers.

Did you use AI tools to help write this code? No
lukestein pushed a commit to lukestein/crosspoint-reader that referenced this pull request Feb 22, 2026
@daveallie @lukestein
chore: Resolve several build warnings (crosspoint-reader#1076)
7362577 
## Summary

* Resolve several build warnings

---

### AI Usage

While CrossPoint doesn't have restrictions on AI tools in contributing,
please be transparent about their usage as it
helps set the right context for reviewers.

Did you use AI tools to help write this code? No
lukestein pushed a commit to lukestein/crosspoint-reader that referenced this pull request Feb 22, 2026
@daveallie @lukestein
chore: Resolve several build warnings (crosspoint-reader#1076)
0da6f7c 
## Summary

* Resolve several build warnings

---

### AI Usage

While CrossPoint doesn't have restrictions on AI tools in contributing,
please be transparent about their usage as it
helps set the right context for reviewers.

Did you use AI tools to help write this code? No
lukestein pushed a commit to lukestein/crosspoint-reader that referenced this pull request Feb 22, 2026
@daveallie @lukestein
chore: Resolve several build warnings (crosspoint-reader#1076)
804db1c 
## Summary

* Resolve several build warnings

---

### AI Usage

While CrossPoint doesn't have restrictions on AI tools in contributing,
please be transparent about their usage as it
helps set the right context for reviewers.

Did you use AI tools to help write this code? No
lukestein pushed a commit to lukestein/crosspoint-reader that referenced this pull request Feb 22, 2026
@daveallie @lukestein
chore: Resolve several build warnings (crosspoint-reader#1076)
0196ab5 
## Summary

* Resolve several build warnings

---

### AI Usage

While CrossPoint doesn't have restrictions on AI tools in contributing,
please be transparent about their usage as it
helps set the right context for reviewers.

Did you use AI tools to help write this code? No
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@osteotek osteotek osteotek approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@daveallie @osteotek