Skip to content

feat: add Ukrainian translation#1065

Merged
osteotek merged 2 commits intocrosspoint-reader:masterfrom
mirus-ua:feat/add-ukrainian-translation
Feb 22, 2026
Merged

feat: add Ukrainian translation#1065
osteotek merged 2 commits intocrosspoint-reader:masterfrom
mirus-ua:feat/add-ukrainian-translation

Conversation

@mirus-ua
Copy link
Contributor

@mirus-ua mirus-ua commented Feb 21, 2026

Summary

Additional Context

  • Add any other information that might be helpful for the reviewer (e.g., performance implications, potential risks,
    specific areas to focus on).

Nope

AI Usage

While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it
helps set the right context for reviewers.

Did you use AI tools to help write this code? < PARTIALLY > as a consistency validation

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 21, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4045c9c and 2b2d340.

📒 Files selected for processing (1)
  • lib/I18n/translations/ukrainian.yaml
✅ Files skipped from review due to trivial changes (1)
  • lib/I18n/translations/ukrainian.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build
📝 Walkthrough

Walkthrough

Adds Ukrainian language support: new translations YAML, Ukrainian string declarations and enum entry in i18n headers, and docs updates listing the Ukrainian translator.

Changes

Cohort / File(s) Summary
Documentation
docs/i18n.md, docs/translators.md		 Added Ukrainian to supported languages and documented the Ukrainian translator; minor reformatting of Catalan translator entry.
I18n Headers
lib/I18n/I18nKeys.h, lib/I18n/I18nStrings.h		 Introduced Language::UKRAINIAN = 10, declared extern const char* const STRINGS_UK[], and wired getStringArray to return STRINGS_UK for Ukrainian.
Translation Data
lib/I18n/translations/ukrainian.yaml		 Added full Ukrainian translations file with UI strings and metadata (+319 lines).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested reviewers

  • osteotek
  • znelson
  • lukestein
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'feat: add Ukrainian translation' directly and clearly describes the main change in the pull request—adding Ukrainian language support.
Description check ✅ Passed The description explains the goal (Ukrainian translation for GUI), references the relevant documentation, and acknowledges AI usage, relating directly to the changeset.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Comment @coderabbitai help to get the list of available commands and usage tips.

znelson
znelson previously approved these changes Feb 21, 2026
View reviewed changes
@mirus-ua
Copy link
Contributor Author

mirus-ua commented Feb 21, 2026

It would be nice to include it to the next 1.1 RC build because I want to check if all translation strings fit corresponding places, and if not push a patch

@osteotek
Copy link
Member

osteotek commented Feb 21, 2026 •
edited
Loading

It would be nice to include it to the next 1.1 RC build because I want to check if all translation strings fit corresponding places, and if not push a patch

You can already check that if you flash firmware from this branch. You can build it yourself or download it from Summary page of build GitHub action

@mirus-ua
Copy link
Contributor Author

mirus-ua commented Feb 22, 2026 •
edited
Loading

It would be nice to include it to the next 1.1 RC build because I want to check if all translation strings fit corresponding places, and if not push a patch

You can already check that if you flash firmware from this branch. You can build it yourself or download it from Summary page of build GitHub action

Thanks for this simple idea

I added a few small changes to prevent text from falling off, and now I'm calm

@znelson can you reapprove as well, please? Sorry for pinging

@mirus-ua mirus-ua requested a review from znelson February 22, 2026 10:36
@ariel-lindemann ariel-lindemann mentioned this pull request Feb 22, 2026
Merged
@mirus-ua
Copy link
Contributor Author

mirus-ua commented Feb 22, 2026

Depending on the merge order of the PR and #1071 I may need to make some tweaks

@osteotek osteotek merged commit 4ccafe5 into crosspoint-reader:master Feb 22, 2026
6 checks passed
lukestein pushed a commit to lukestein/crosspoint-reader that referenced this pull request Feb 22, 2026
@mirus-ua @lukestein
feat: add Ukrainian translation (crosspoint-reader#1065)
1594a9c 
## Summary

* **What is the goal of this PR?**
A Ukrainian translation for the GUI

* **What changes are included?**
Everything according to
https://github.com/crosspoint-reader/crosspoint-reader/blob/master/docs/i18n.md

## Additional Context

* Add any other information that might be helpful for the reviewer
(e.g., performance implications, potential risks,
  specific areas to focus on).

Nope

---

### AI Usage

While CrossPoint doesn't have restrictions on AI tools in contributing,
please be transparent about their usage as it
helps set the right context for reviewers.

Did you use AI tools to help write this code? _**< PARTIALLY >**_ as a
consistency validation
lukestein pushed a commit to lukestein/crosspoint-reader that referenced this pull request Feb 22, 2026
@mirus-ua @lukestein
feat: add Ukrainian translation (crosspoint-reader#1065)
dd91308 
## Summary

* **What is the goal of this PR?**
A Ukrainian translation for the GUI

* **What changes are included?**
Everything according to
https://github.com/crosspoint-reader/crosspoint-reader/blob/master/docs/i18n.md

## Additional Context

* Add any other information that might be helpful for the reviewer
(e.g., performance implications, potential risks,
  specific areas to focus on).

Nope

---

### AI Usage

While CrossPoint doesn't have restrictions on AI tools in contributing,
please be transparent about their usage as it
helps set the right context for reviewers.

Did you use AI tools to help write this code? _**< PARTIALLY >**_ as a
consistency validation
iandchasse pushed a commit to iandchasse/crosspoint-reader-minRead that referenced this pull request Feb 22, 2026
@mirus-ua @iandchasse
feat: add Ukrainian translation (crosspoint-reader#1065)
5e5dabb 
## Summary

* **What is the goal of this PR?**
A Ukrainian translation for the GUI

* **What changes are included?**
Everything according to
https://github.com/crosspoint-reader/crosspoint-reader/blob/master/docs/i18n.md

## Additional Context

* Add any other information that might be helpful for the reviewer
(e.g., performance implications, potential risks,
  specific areas to focus on).

Nope

---

### AI Usage

While CrossPoint doesn't have restrictions on AI tools in contributing,
please be transparent about their usage as it
helps set the right context for reviewers.

Did you use AI tools to help write this code? _**< PARTIALLY >**_ as a
consistency validation
lukestein pushed a commit to lukestein/crosspoint-reader that referenced this pull request Feb 22, 2026
@mirus-ua @lukestein
feat: add Ukrainian translation (crosspoint-reader#1065)
dca2ad8 
## Summary

* **What is the goal of this PR?**
A Ukrainian translation for the GUI

* **What changes are included?**
Everything according to
https://github.com/crosspoint-reader/crosspoint-reader/blob/master/docs/i18n.md

## Additional Context

* Add any other information that might be helpful for the reviewer
(e.g., performance implications, potential risks,
  specific areas to focus on).

Nope

---

### AI Usage

While CrossPoint doesn't have restrictions on AI tools in contributing,
please be transparent about their usage as it
helps set the right context for reviewers.

Did you use AI tools to help write this code? _**< PARTIALLY >**_ as a
consistency validation
lukestein pushed a commit to lukestein/crosspoint-reader that referenced this pull request Feb 22, 2026
@mirus-ua @lukestein
feat: add Ukrainian translation (crosspoint-reader#1065)
7b83a25 
## Summary

* **What is the goal of this PR?**
A Ukrainian translation for the GUI

* **What changes are included?**
Everything according to
https://github.com/crosspoint-reader/crosspoint-reader/blob/master/docs/i18n.md

## Additional Context

* Add any other information that might be helpful for the reviewer
(e.g., performance implications, potential risks,
  specific areas to focus on).

Nope

---

### AI Usage

While CrossPoint doesn't have restrictions on AI tools in contributing,
please be transparent about their usage as it
helps set the right context for reviewers.

Did you use AI tools to help write this code? _**< PARTIALLY >**_ as a
consistency validation
lukestein pushed a commit to lukestein/crosspoint-reader that referenced this pull request Feb 22, 2026
@mirus-ua @lukestein
feat: add Ukrainian translation (crosspoint-reader#1065)
667d1ad 
## Summary

* **What is the goal of this PR?**
A Ukrainian translation for the GUI

* **What changes are included?**
Everything according to
https://github.com/crosspoint-reader/crosspoint-reader/blob/master/docs/i18n.md

## Additional Context

* Add any other information that might be helpful for the reviewer
(e.g., performance implications, potential risks,
  specific areas to focus on).

Nope

---

### AI Usage

While CrossPoint doesn't have restrictions on AI tools in contributing,
please be transparent about their usage as it
helps set the right context for reviewers.

Did you use AI tools to help write this code? _**< PARTIALLY >**_ as a
consistency validation
@martinbrook martinbrook mentioned this pull request Feb 22, 2026
Closed
This was referenced Feb 23, 2026
Merged
Merged
Closed
Merged
Merged
Merged
Closed
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@znelson znelson znelson approved these changes

@osteotek osteotek osteotek approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mirus-ua @osteotek @znelson