fix: Shorten "Forget Wifi" button labels to fit on button by lukestein · Pull Request #1045 · crosspoint-reader/crosspoint-reader

lukestein · 2026-02-20T18:55:28Z

Summary

Resolves #1035

Additional Context

Shortened strings (all based on existing ones) confirmed using Google Translate, but I am not a native speaker of languages other than English

AI Usage

Did you use AI tools to help write this code? Partially

coderabbitai · 2026-02-20T18:55:36Z

No actionable comments were generated in the recent review. 🎉

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9c55c15 and 2a3f3eb.

📒 Files selected for processing (9)

lib/I18n/translations/czech.yaml
lib/I18n/translations/english.yaml
lib/I18n/translations/french.yaml
lib/I18n/translations/german.yaml
lib/I18n/translations/portuguese.yaml
lib/I18n/translations/romanian.yaml
lib/I18n/translations/russian.yaml
lib/I18n/translations/spanish.yaml
lib/I18n/translations/swedish.yaml

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2026-02-12T06:57:35.955Z

Learnt from: CaptainFrito
Repo: crosspoint-reader/crosspoint-reader PR: 725
File: src/activities/network/CalibreConnectActivity.cpp:218-264
Timestamp: 2026-02-12T06:57:35.955Z
Learning: In src/activities/network/CalibreConnectActivity.cpp, button hints (« Exit) are intentionally omitted from the SERVER_STARTING and ERROR states—only the SERVER_RUNNING state displays navigation hints. This is a deliberate design decision by the author.

Applied to files:

lib/I18n/translations/german.yaml
lib/I18n/translations/russian.yaml
lib/I18n/translations/english.yaml

🔇 Additional comments (9)

lib/I18n/translations/french.yaml (1)

269-269: LGTM — concise label aligns with overflow fix.
Shortening the button label to “Oublier” matches the PR objective and should help avoid UI overflow.

lib/I18n/translations/czech.yaml (1)

269-269: LGTM — concise label aligns with overflow fix.
“Zapomenout” is a clear, shorter CTA and fits the goal of preventing overflow.

lib/I18n/translations/portuguese.yaml (1)

269-269: LGTM — concise label aligns with overflow fix.
“Esquecer” keeps the intent while reducing length for UI fit.

lib/I18n/translations/russian.yaml (1)

269-269: LGTM — concise label aligns with overflow fix.
“Забыть” is a clean, shorter CTA and should fit the button well.

lib/I18n/translations/english.yaml (1)

269-269: LGTM — concise label aligns with overflow fix.
“Forget” is clear and significantly shorter, which should mitigate overflow.

lib/I18n/translations/swedish.yaml (1)

269-269: LGTM — concise label aligns with overflow fix.
“Glöm” is a short, clear CTA that should help with the layout.

lib/I18n/translations/romanian.yaml (1)

268-268: LGTM — concise label aligns with overflow fix.
“Uitaţi” keeps the intended meaning while staying compact.

lib/I18n/translations/spanish.yaml (1)

269-269: LGTM — concise label aligns with overflow fix.
“Olvidar” is a good shorter CTA to prevent UI overflow.

lib/I18n/translations/german.yaml (1)

269-269: LGTM!

The shortened label "Entfernen" is grammatically correct German and appropriate in context. The surrounding dialog text (STR_FORGET_NETWORK on line 41 or STR_FORGET_AND_REMOVE on line 268) provides sufficient context for the user to understand the button's action, making the abbreviated label clear while resolving the overflow issue.

📝 Walkthrough

Walkthrough

This pull request updates the STR_FORGET_BUTTON translation key across nine language files (Czech, English, French, German, Portuguese, Romanian, Russian, Spanish, and Swedish) by shortening the button text to address UI overflow issues.

Changes

Cohort / File(s)	Summary
Translation Updates `lib/I18n/translations/czech.yaml`, `lib/I18n/translations/english.yaml`, `lib/I18n/translations/french.yaml`, `lib/I18n/translations/german.yaml`, `lib/I18n/translations/portuguese.yaml`, `lib/I18n/translations/romanian.yaml`, `lib/I18n/translations/russian.yaml`, `lib/I18n/translations/spanish.yaml`, `lib/I18n/translations/swedish.yaml`	Shortened `STR_FORGET_BUTTON` text in all language files to prevent button label overflow (e.g., "Forget network" → "Forget", "Oublier le réseau" → "Oublier").

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: shortening button labels for the Forget WiFi button across multiple language files.
Description check	✅ Passed	The description is related to the changeset, referencing issue `#1035` and explaining the purpose of shortening strings with validation via Google Translate.
Linked Issues check	✅ Passed	The PR fully addresses the requirements from issue `#1035` by shortening the STR_FORGET_BUTTON labels across all language files to prevent text overflow.
Out of Scope Changes check	✅ Passed	All changes are in-scope, limited to updating STR_FORGET_BUTTON translation values across 8 language files to resolve the text overflow issue.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

ariel-lindemann · 2026-02-20T19:18:42Z

coud you change it for the newly added romanian strings as well? should be simply Uitaţi

## Summary Just fixed a typo `Xtink` -> `Xteink` --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**< NO >**_

## Summary * **What is the goal of this PR?** (e.g., Implements the new feature for file uploading.) To add upport for a romanian language user interface. * **What changes are included?** A new i18n file `romanian.yml` ## Additional Context * Add any other information that might be helpful for the reviewer (e.g., performance implications, potential risks, specific areas to focus on). --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**< NO >**_

lukestein · 2026-02-20T19:53:50Z

coud you change it for the newly added romanian strings as well? should be simply Uitaţi

Done! Thanks.

elvisgastelum · 2026-02-21T02:17:05Z

lib/I18n/translations/spanish.yaml

 STR_CALIBRE_DESC: "Utilice las transferencias dispositivos inalámbricos de calibre"
 STR_FORGET_AND_REMOVE: "Olvidar la red y eliminar la contraseña guardada?"
-STR_FORGET_BUTTON: "Olvidar la red"
+STR_FORGET_BUTTON: "Olvidar"


As a native Spanish speaker, I can confirm this is right ✅

…-reader#1045)

Shorten "Forget Wifi" button labels to fit on button

4a403e3

lukestein mentioned this pull request Feb 20, 2026

fix: fixed network list overlapping with footer #962

Draft

lukestein marked this pull request as ready for review February 20, 2026 18:57

lukestein requested a review from osteotek February 20, 2026 19:00

lukestein mentioned this pull request Feb 20, 2026

chore(release): 1.1.0 Release Candidate #992

Merged

osteotek previously approved these changes Feb 20, 2026

View reviewed changes

lukestein requested a review from a team February 20, 2026 19:08

arnaugamez and others added 3 commits February 20, 2026 14:51

Shorten Romanian "Forget Wifi" button label

cf99c22

lukestein dismissed osteotek’s stale review via cf99c22 February 20, 2026 19:51

Merge branch 'master' into fix/forget-network-button-text

2a3f3eb

lukestein requested a review from osteotek February 20, 2026 19:54

osteotek approved these changes Feb 20, 2026

View reviewed changes

lukestein requested a review from a team February 20, 2026 22:41

CaptainFrito approved these changes Feb 21, 2026

View reviewed changes

lukestein merged commit 693dba4 into crosspoint-reader:master Feb 21, 2026
6 checks passed

elvisgastelum reviewed Feb 21, 2026

View reviewed changes

DaniPhii mentioned this pull request Feb 21, 2026

"Forget network" text flows out of text box. #1062

Closed

lukestein added a commit to lukestein/crosspoint-reader that referenced this pull request Feb 21, 2026

fix: Shorten "Forget Wifi" button labels to fit on button (crosspoint…

4c0a1f8

…-reader#1045)

daveallie pushed a commit that referenced this pull request Feb 22, 2026

fix: Shorten "Forget Wifi" button labels to fit on button (#1045)

45d19f6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: Shorten "Forget Wifi" button labels to fit on button#1045

fix: Shorten "Forget Wifi" button labels to fit on button#1045
lukestein merged 5 commits intocrosspoint-reader:masterfrom
lukestein:fix/forget-network-button-text

lukestein commented Feb 20, 2026

Uh oh!

coderabbitai bot commented Feb 20, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Uh oh!

ariel-lindemann commented Feb 20, 2026

Uh oh!

lukestein commented Feb 20, 2026

Uh oh!

Uh oh!

elvisgastelum Feb 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

lukestein commented Feb 20, 2026

Summary

Additional Context

AI Usage

Uh oh!

coderabbitai bot commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Uh oh!

ariel-lindemann commented Feb 20, 2026

Uh oh!

lukestein commented Feb 20, 2026

Uh oh!

Uh oh!

elvisgastelum Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

coderabbitai bot commented Feb 20, 2026 •

edited

Loading