fix flaky test by guaranteeing execution order#96
Merged
arielsepton merged 1 commit intocrossplane-contrib:mainfrom Jun 2, 2025
Merged
fix flaky test by guaranteeing execution order#96arielsepton merged 1 commit intocrossplane-contrib:mainfrom
arielsepton merged 1 commit intocrossplane-contrib:mainfrom
Conversation
Signed-off-by: Nico Duldhardt <[email protected]>
klaudworks
force-pushed
the
fix-flaky-test
branch
from
7d32832 to
d45eac9
Compare
arielsepton
approved these changes
Jun 2, 2025
barunavo
pushed a commit
to barunavo/provider-http
that referenced
this pull request
Nov 17, 2025
Signed-off-by: Nico Duldhardt <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes the unit test execution order by using a slice with deterministic iteration order instead of a map with indeterministic execution order.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
make -j2 test