Skip to content

test(e2e): add missing poll intervals to wait.For calls#7285

Closed
moeritze wants to merge 1 commit into
crossplane:mainfrom
moeritze:fix/issue-5671-missing-poll-intervals
Closed

test(e2e): add missing poll intervals to wait.For calls#7285
moeritze wants to merge 1 commit into
crossplane:mainfrom
moeritze:fix/issue-5671-missing-poll-intervals

Conversation

@moeritze

@moeritze moeritze commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

Description of your changes

Three wait.For calls in test/e2e/funcs/feature.go were missing
wait.WithInterval(DefaultPollInterval), unlike all other wait.For calls in
the file. Without an explicit interval, these calls use the e2e-framework's
default polling behavior, which is inconsistent and can contribute to flaky test
results.

This adds the missing interval option to:

  • ClaimUnderTestMustNotChangeWithin
  • CompositeUnderTestMustNotChangeWithin
  • CompositeResourceMustMatchWithin

Refs #5671

I have:

@moeritze
test(e2e): add missing poll intervals to wait.For calls
1e84357 
Three wait.For calls in test/e2e/funcs/feature.go were missing
wait.WithInterval(DefaultPollInterval), unlike all other wait.For
calls in the file. Without an explicit interval, these calls use the
e2e-framework default polling behavior, which can contribute to flaky
test results.

Add the missing interval option to ClaimUnderTestMustNotChangeWithin,
CompositeUnderTestMustNotChangeWithin, and
CompositeResourceMustMatchWithin for consistency.

Signed-off-by: Moritz Röseler <[email protected]>
@moeritze
moeritze requested a review from a team as a code owner April 9, 2026 08:06
@moeritze
moeritze requested a review from negz April 9, 2026 08:06
@coderabbitai

coderabbitai Bot commented Apr 9, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 12fc61bd-dd3c-4636-915c-20573529bfad

📥 Commits

Reviewing files that changed from the base of the PR and between 8f8e265 and 1e84357.

📒 Files selected for processing (1)
  • test/e2e/funcs/feature.go
📝 Walkthrough

Walkthrough

Added explicit polling interval configuration to three wait-based test functions. The wait.WithInterval(DefaultPollInterval) parameter is now included alongside existing timeout settings to make polling behavior explicit, affecting test operations for claims and composite resources.

Changes

Cohort / File(s) Summary
Test Polling Configuration
test/e2e/funcs/feature.go		 Added wait.WithInterval(DefaultPollInterval) to wait.For(...) calls in ClaimUnderTestMustNotChangeWithin, CompositeUnderTestMustNotChangeWithin, and CompositeResourceMustMatchWithin to explicitly configure polling intervals during timeout windows.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding missing poll intervals to wait.For calls in e2e tests, is within the 72 character limit, and uses the appropriate test scope prefix.
Description check ✅ Passed The description clearly explains what was changed, why it matters (consistency and reducing test flakiness), which functions were affected, and includes a reference to the related issue.
Breaking Changes ✅ Passed The PR modifies only test/e2e/funcs/feature.go, which is located in the test directory structure and explicitly falls outside the scope of the breaking changes check that applies only to files under apis/** or cmd/** directories.
Feature Gate Requirement ✅ Passed This pull request does not introduce any new experimental features or modifications to the apis/** directory. The changes are limited to test/e2e/funcs/feature.go, adding the wait.WithInterval(DefaultPollInterval) parameter to three test helper functions for consistency with other similar test functions in the same file. These are purely test infrastructure improvements to reduce test flakiness and ensure consistent polling behavior—no feature flags are required for such test code modifications.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@amarkdotdev amarkdotdev mentioned this pull request Jun 26, 2026
Open
17 tasks
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

Crossplane does not currently have enough maintainers to address every issue and pull request. This pull request has been automatically marked as stale because it has had no activity in the last 90 days. It will be closed in 14 days if no further activity occurs. Adding a comment starting with /fresh will mark this PR as not stale.

@github-actions github-actions Bot added the stale label Jul 9, 2026
@github-actions github-actions Bot closed this Jul 24, 2026
@jbw976 jbw976 mentioned this pull request Jul 24, 2026
Merged
7 tasks
@jbw976

jbw976 commented Jul 24, 2026

Copy link
Copy Markdown
Member

So sorry @moeritze, I noticed this PR today when the stalebot closed it. When coming to check it, I noticed it look quite familiar to what #7547 was also solving, which we did review and are ready to merge.

To be fair and give you credit for building this solution as well, I've gone ahead and amended the commit in that PR so that you are listed as a co-author too as described in #7547 (review). When that is merged, both you and @amarkdotdev will have credit for the contribution.

Sorry again that we did not get to this PR and hopefully you'll still feel encouraged to contribute again in the future! 🙇‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@negz negz Awaiting requested review from negz negz is a code owner automatically assigned from crossplane/crossplane-maintainers

Assignees

No one assigned

Labels

stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@moeritze @jbw976