Repository navigation
deps: Update crossplane-runtime to v2.2.0 - #7150
Conversation
Signed-off-by: Adam Wolfe Gordon <[email protected]>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The latest controller-runtime has deprecated some fields, types, and methods we use. This update was pulled in as part of our crossplane-runtime update and in some cases crossplane-runtime is still using deprecated types in its APIs. In the interest of stability, we're not going to try and fix these issues properly in the v2.2 release branch. Add nolint directives for them for now, with TODOs to fix them after the v2.2 release. Signed-off-by: Adam Wolfe Gordon <[email protected]>
haarchri
left a comment
haarchri
left a comment
There was a problem hiding this comment.
LGTM for now - can we open an tracking issue ?
jbw976
left a comment
jbw976
left a comment
There was a problem hiding this comment.
can you add a bit of a description for why these linter ignores need to be added? I'm not immediately understanding of these are super safe or a bit risky 😉
and then having a tracking issue we can add to the v2.3 roadmap will be very useful as well.
Description of your changes
Update crossplane-runtime dependency for the v2.2.0 release.
Add
nolints for our usage of a couple of newly-deprecated controller-runtime APIs: theEventRecorderAPI and the older SSA API. In both cases, the change to use the new ones should be relatively straightforward, but in the interest of stability we'll wait to do it on main after the v2.2.0 release rather than here in the release branch.I have:
./nix.sh flake checkto ensure this PR is ready for review.- [ ] Added or updated unit tests.- [ ] Added or updated e2e tests.- [ ] Linked a PR or a docs tracking issue to document this change.- [ ] Addedbackport release-x.ylabels to auto-backport this PR.- [ ] Followed the API promotion workflow if this PR introduces, removes, or promotes an API.