[v2] Don't explicitly "unpublish" connection details #6327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The v2 branch only supports publishing connection details as Kubernetes secrets. We don't need to explicitly unpublish them, because we rely on Kubernetes garbage collection to delete connection secrets. We needed to explicitly unpublish connection details from e.g. Vault, but that feature (external secret stores) is removed in the v2 branch. Signed-off-by: Nic Cope <[email protected]>
jbw976
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
The v2 branch only supports publishing connection details as Kubernetes secrets. We don't need to explicitly unpublish them, because we rely on Kubernetes garbage collection to delete connection secrets.
We needed to explicitly unpublish connection details from e.g. Vault, but that feature (external secret stores) is removed in the v2 branch.
I have:
earthly +reviewableto ensure this PR is ready for review.Added or updated e2e tests.Linked a PR or a docs tracking issue to document this change.Addedbackport release-x.ylabels to auto-backport this PR.Followed the API promotion workflow if this PR introduces, removes, or promotes an API.Need help with this checklist? See the cheat sheet.