Skip to content

Conversation

@turkenh
Copy link
Member

@turkenh turkenh commented Dec 5, 2024

Description of your changes

This PR extends the existing lifecycle e2e tests with downgrade to catch issue like this in e2e: #6148

It basically installs the current build and downgrades it back to the prior release.
I could validate that it can catch if I attempt promoting Usage API to v1beta1 and bump the storage version at the same time.

I have:

  • Read and followed Crossplane's contribution process.
  • Run earthly +reviewable to ensure this PR is ready for review.
  • Added or updated unit tests.
  • Added or updated e2e tests.
  • Linked a PR or a docs tracking issue to document this change.
  • Added backport release-x.y labels to auto-backport this PR.

Need help with this checklist? See the cheat sheet.

@turkenh turkenh requested review from a team and negz as code owners December 5, 2024 07:35
@turkenh turkenh requested review from bobh66 and phisco December 5, 2024 07:35
@jbw976 jbw976 mentioned this pull request Dec 5, 2024
17 tasks
@jbw976 jbw976 added this to the v1.19 milestone Dec 5, 2024
Copy link
Member

@jbw976 jbw976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me @turkenh, thanks for adding this downgrade test!! 🙇‍♂️

@turkenh turkenh merged commit 0d806ba into crossplane:main Dec 6, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants