fix(e2e): install prior version to upgrade fixing lifecycle tests on older branches #6089
Conversation
Signed-off-by: Hasan Turken <[email protected]>
Signed-off-by: Hasan Turken <[email protected]>
turkenh
force-pushed
the
e2e-upgrade-fix
branch
from
7f3fd73 to
47d81ce
Compare
phisco
left a comment
phisco
left a comment
There was a problem hiding this comment.
trusting the bash magic 😆 maybe that could have been pushed down to Go, just passing the branch, but would have been less explicit.
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-1.16
git worktree add -d .worktree/backport-6089-to-release-1.16 origin/release-1.16
cd .worktree/backport-6089-to-release-1.16
git switch --create backport-6089-to-release-1.16
git cherry-pick -x 3374a75e557e3e6b759b220ed3210a77d9860802 47d81cea96fc68eaede99f78a3dbfd9662c9af70 |
|
Git push to origin failed for release-1.17 with exitcode 1 |
|
Git push to origin failed for release-1.18 with exitcode 1 |
Yeah, that was the hardest part of this PR 😬 Both deciding where to calculate from branch to version and eventually doing in bash. My rationale for doing in outside e2e tests (not inside go) is that this enables extending tests further against multiple prior versions with a test matrix in GitHub CI. |
2 participants
Description of your changes
This PR fixes
TestCrossplaneLifecycle/TestCrossplaneLifecycleUpgrade/UpgradeCrossplanefor older branches by installing the prior Crossplane version from the stable chart repository and then upgrading. Previously, we always install latest stable version and try upgrading to the local chart. This means downgrading in that and usually fails unexpectedly.See this comment for the latest failure.
I expect the changes here having no effect on main but fixing release branches after backporting. Verified with #6082.
Fixes #6085
I have:
earthly +reviewableto ensure this PR is ready for review.Added or updated unit tests.Added or updated e2e tests.Linked a PR or a docs tracking issue to document this change.backport release-x.ylabels to auto-backport this PR.Need help with this checklist? See the cheat sheet.