Skip to content

Conversation

@turkenh
Copy link
Member

@turkenh turkenh commented Nov 4, 2024

Description of your changes

See the PR description of crossplane/crossplane-runtime#786

Related issue: #6043

I have:

Need help with this checklist? See the cheat sheet.

@turkenh turkenh requested review from a team, negz and phisco as code owners November 4, 2024 12:53
@turkenh turkenh requested a review from bobh66 November 4, 2024 12:53
@turkenh turkenh marked this pull request as draft November 4, 2024 12:59
@turkenh
Copy link
Member Author

turkenh commented Nov 4, 2024

Draft until crossplane/crossplane-runtime#786 is merged, otherwise ready for reviews.

@turkenh turkenh changed the title Fix unknown fields warnings by avoiding setting non-existing fields Fix unknown fields warnings and suppress finalizer ones Nov 4, 2024
@turkenh turkenh changed the title Fix unknown fields warnings and suppress finalizer ones Fix unknown fields warnings Nov 5, 2024
Signed-off-by: Hasan Turken <[email protected]>
@turkenh turkenh marked this pull request as ready for review November 5, 2024 07:33
@turkenh turkenh merged commit 82e5465 into crossplane:main Nov 5, 2024
@github-actions
Copy link

github-actions bot commented Nov 5, 2024

Backport failed for release-1.18, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-1.18
git worktree add -d .worktree/backport-6064-to-release-1.18 origin/release-1.18
cd .worktree/backport-6064-to-release-1.18
git switch --create backport-6064-to-release-1.18
git cherry-pick -x 6e2ae7e58ad0d93d116c8f9722f8ea305a7f8ce8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants