Skip to content

[release-1.16] Backport ImageConfig API for auth support#6052

Merged
turkenh merged 1 commit into
crossplane:release-1.16from
turkenh:backport-6000-to-release-1.16
Nov 5, 2024
Merged

[release-1.16] Backport ImageConfig API for auth support#6052
turkenh merged 1 commit into
crossplane:release-1.16from
turkenh:backport-6000-to-release-1.16

Conversation

@turkenh

@turkenh turkenh commented Nov 1, 2024

Copy link
Copy Markdown
Member

Description of your changes

This PR backports #6000 to release-1.16.

I had to use a temporary branch on my fork to squash into a single commit and cherry-pick it because of the number of conflicts I had to resolve in multiple times in each commit.

I have:

  • Read and followed Crossplane's contribution process.
  • Run earthly +reviewable to ensure this PR is ready for review.
  • Added or updated unit tests.
  • Added or updated e2e tests.
  • Linked a PR or a docs tracking issue to document this change.
  • Added backport release-x.y labels to auto-backport this PR.

Need help with this checklist? See the cheat sheet.

Signed-off-by: Hasan Turken <[email protected]>
(cherry picked from commit 7c80746)
@turkenh
turkenh requested a review from a team as a code owner November 1, 2024 12:37
@turkenh
turkenh requested a review from bobh66 November 1, 2024 12:37
@turkenh

turkenh commented Nov 3, 2024

Copy link
Copy Markdown
Member Author

We have been observing e2e failures on this release branch, before as well:

Still considering the size of this PR, I did locally run all failing suites, base, usage, and ssa-claims, and ensured that they passed at least once. Also did some quick sanity checks so, feeling good to ignore failing e2e's.

@ezgidemirel ezgidemirel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants