feat(xfn): Consider composite ready state in function response #6021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
negz
reviewed
Oct 23, 2024
negz
reviewed
Oct 23, 2024
negz
reviewed
Oct 23, 2024
negz
reviewed
Oct 23, 2024
| // ConditionsOverride allows the composition process to force | ||
| // a specific condition status, unlike Conditions which does not allow | ||
| // setting system conditions. | ||
| ConditionsOverride []xpv1.Condition |
Member
There was a problem hiding this comment.
I wonder if we could use a special TargetdCondition variant. i.e. Add a System field and just use that internally to surface these conditions.
Contributor
Author
There was a problem hiding this comment.
I tried this but it does work as intended since the custom conditions update (which uses the Conditions array) is performed in handleCommonCompositionResult() but the system conditions are set in updateXRConditions().
Contributor
Author
There was a problem hiding this comment.
I changed to a new type CompositeResource that is analog to ComposedResource and contains a Ready *bool property.
MisterMX
force-pushed
the
feat/function-composite-ready-state
branch
3 times, most recently
from
abcea6b to
3273978
Compare
Signed-off-by: Maximilian Blatt <[email protected]>
MisterMX
force-pushed
the
feat/function-composite-ready-state
branch
from
3273978 to
eea8f82
Compare
phisco
added
backport release-1.18
and removed
backport release-1.16
backport release-1.17
labels
negz
approved these changes
Oct 31, 2024
|
Successfully created backport PR for |
This was referenced Nov 8, 2024
Report XR as not ready if required patch failing
crossplane-contrib/function-patch-and-transform#152
Closed
This was referenced Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Marks the composite as ready or unready if the if
.Desired.Composite.Readyfield is set explicitly.Fixes #6020
I have:
earthly +reviewableto ensure this PR is ready for review.[ ] Added or updated unit tests.[ ] Added or updated e2e tests.[ ] Linked a PR or a docs tracking issue to document this change.backport release-x.ylabels to auto-backport this PR.Need help with this checklist? See the cheat sheet.