Crossplane Helm chart service account creation flag #5870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 7, 2024 10:58
Signed-off-by: Roy Polansky <[email protected]>
Signed-off-by: Roy Polansky <[email protected]>
Signed-off-by: Roy Polansky <[email protected]>
Signed-off-by: Roy Polansky <[email protected]>
Signed-off-by: Roy Polansky <[email protected]>
phisco
reviewed
Aug 8, 2024
6 tasks
phisco
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR adds a support in the Helm chart, in order to control the creation of Crossplane service account.
Currently there's no option to avoid the creation of Crossplane service account.
Having the ability to control its creation can be useful in cases, where we already have a service account that was created outside Crossplane's chart that we would like to use.
I have:
earthly +reviewableto ensure this PR is ready for review.Added or updated unit tests.Added or updated e2e tests.Linked a PR or a docs tracking issue to document this change.Addedbackport release-x.ylabels to auto-backport this PR.Need help with this checklist? See the cheat sheet.