Skip to content

Bump crossplane-runtime to v1.17.0-rc.0#5652

Merged
jbw976 merged 2 commits into
crossplane:masterfrom
jbw976:bump-runtime
May 7, 2024
Merged

Bump crossplane-runtime to v1.17.0-rc.0#5652
jbw976 merged 2 commits into
crossplane:masterfrom
jbw976:bump-runtime

Conversation

@jbw976

@jbw976 jbw976 commented May 7, 2024

Copy link
Copy Markdown
Member

Description of your changes

This PR simply bumps the crossplane-runtime dependency to v1.17.0-rc.0, as per the code freeze steps in crossplane/release#9, specifically:

(On the Master Branch) created and merged a PR bumping the Crossplane Runtime dependency to the release candidate tag from master, vX.Y+1.0-rc.0.

I have:

Need help with this checklist? See the cheat sheet.

@jbw976
jbw976 requested a review from a team as a code owner May 7, 2024 08:13
@jbw976
jbw976 requested a review from negz May 7, 2024 08:13
jbw976
jbw976 commented May 7, 2024
View reviewed changes

@jbw976 jbw976 left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, looks like check-diff is failing with these new changes from crossplane-runtime, I'll need to look into that:

08:14:51 [FAIL] There are uncommitted changes after running make generate. Please ensure you commit all generated files in this branch after running make generate.
make: *** [build/makelib/common.mk:446: check-diff] Error 1

https://github.com/crossplane/crossplane/actions/runs/8981967983/job/24668568512?pr=5652

@jbw976
chore: add observedGeneration field to core CRDs
a30eeb2 
This new field is a result of the latest bump of crossplane-runtime
and all changes in this commit were generated by `make generate`.

Signed-off-by: Jared Watts <[email protected]>
@jbw976

jbw976 commented May 7, 2024

Copy link
Copy Markdown
Member Author

@phisco @turkenh this is ready for review again - I've addressed the check-diff failure simply by running make generate 😇

@jbw976 jbw976 mentioned this pull request May 7, 2024
Closed
49 tasks
@jbw976

jbw976 commented May 7, 2024

Copy link
Copy Markdown
Member Author

Hmm, the same e2e test failed in 2 different suites, which I don't personally know to be flaky:

--- FAIL: TestConfigurationWithDependency (93.18s)
    --- FAIL: TestConfigurationWithDependency/TestConfigurationWithDependency (93.18s)
        --- PASS: TestConfigurationWithDependency/TestConfigurationWithDependency/ConfigurationIsHealthy (6.00s)
        --- PASS: TestConfigurationWithDependency/TestConfigurationWithDependency/RequiredProviderIsHealthy (12.50s)

I'll investigate this error locally before proceeding 🤓

@jbw976

jbw976 commented May 7, 2024

Copy link
Copy Markdown
Member Author

I'm unable to repro this e2e test failure locally after running it a handful of times:

❯ make e2e E2E_TEST_FLAGS="-test.v -test.failfast -fail-fast -destroy-kind-cluster=false --kind-logs-location ./logs-kind --test-suite base -test.run ^TestConfigurationWithDependency"
...
--- PASS: TestConfigurationWithDependency (21.11s)
    --- PASS: TestConfigurationWithDependency/TestConfigurationWithDependency (21.11s)
        --- PASS: TestConfigurationWithDependency/TestConfigurationWithDependency/ConfigurationIsHealthy (11.01s)
        --- PASS: TestConfigurationWithDependency/TestConfigurationWithDependency/RequiredProviderIsHealthy (8.51s)
PASS
11:08:49 [ OK ] Run E2E tests

In the runs here on this PR, it looks like the provider-nop was unable to be deleted, but it's not clear why:

    env.go:428: Deleted resources from test/e2e/manifests/pkg/configuration/dependency/provider-dependency.yaml (matched 1 manifests)
    env.go:428: Waiting 1m0s for Provider.pkg.crossplane.io crossplane-contrib-provider-nop to be deleted...
W0507 08:47:11.905335    6012 warnings.go:70] v1 ComponentStatus is deprecated in v1.19+
W0507 08:47:24.096660    6012 warnings.go:70] ControllerConfig.pkg.crossplane.io/v1alpha1 is deprecated. Use DeploymentRuntimeConfig from pkg.crossplane.io/v1beta1 instead.
    env.go:428: resources not deleted: context deadline exceeded:

I don't see a deletion timestamp on the Provider or ProviderRevision objects in the test debug output, which is odd. I don't see immediate evidence they are undergoing a deletion attempt, even though it says we did request a deletion above 🤔

The same test is passing on a similar PR that bumps crossplane-runtime in the release branch: https://github.com/crossplane/crossplane/actions/runs/8982458339/job/24670118653?pr=5653. So perhaps this test is flaky - something to look more into but perhaps not blocking this specific PR.

@jbw976

jbw976 commented May 7, 2024

Copy link
Copy Markdown
Member Author

Plenty of instances of this same failure previously in master before this PR:

I'll take a note of the flaky tests we're seeing and capture it in an issue so we can improve on them, but I don't think this is blocking this PR 😌

@jbw976 jbw976 mentioned this pull request May 7, 2024
Merged
6 tasks
@phisco

phisco commented May 7, 2024

Copy link
Copy Markdown
Contributor

Yes, we can address this before the release. I agree it shouldn't block the code freeze process

@jbw976
jbw976 merged commit 68bb551 into crossplane:master May 7, 2024
@jbw976 jbw976 mentioned this pull request May 10, 2024
Open
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phisco phisco phisco approved these changes
@negz negz Awaiting requested review from negz negz was automatically assigned from crossplane/crossplane-maintainers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jbw976 @phisco