Fix/eager logger interpolation and dead options#662
Merged
crmne merged 2 commits intoMar 9, 2026
Merged
Conversation
Same issue fixed in `setup_logging` (merged via crmne#562). Faraday's logging formatter (v2.14.1) only recognizes `:headers`, `:bodies`, `:errors`, and `:log_level`. Ref: https://github.com/lostisland/faraday/blob/v2.14.1/lib/faraday/logging/formatter.rb#L11
Same pattern fixed in 90b8dd1 for other providers (e.g. gemini/images.rb). This one was missed.
crmne
approved these changes
Mar 9, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #662 +/- ##
=======================================
Coverage 81.50% 81.50%
=======================================
Files 116 116
Lines 5483 5483
Branches 1432 1432
=======================================
Hits 4469 4469
Misses 1014 1014 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Commit 1: Removes response: false from Connection.basic — the same unrecognized Faraday logger option removed from setup_logging in #661. Faraday's logging formatter (v2.14.1) only recognizes :headers, :bodies, :errors, and :log_level (source).
Commit 2: Converts the remaining eager logger.debug call in OpenRouter::Images to lazy block form. This is the same pattern fixed across other providers in 90b8dd1 — the identical call in gemini/images.rb was converted but this one was missed.
Type of change
Scope check
Required for new features
PRs for new features or enhancements without a prior approved issue will be closed.
Quality check
overcommit --installand all hooks passbundle exec rake vcr:record[provider_name]bundle exec rspecmodels.json,aliases.json)AI-generated code
API changes