Fix chat response job template to use String#empty? instead of #blank? when streaming#537
Closed
kryzhovnik wants to merge 1 commit into
Closed
Fix chat response job template to use String#empty? instead of #blank? when streaming#537kryzhovnik wants to merge 1 commit into
kryzhovnik wants to merge 1 commit into
Conversation
String#blank? returns true for whitespace-only chunks (including newlines), so it can drop streamed content: ```ruby "\n".blank? # => true ``` String#empty? only rejects zero-length strings: ```ruby "\n".empty? #=> false "".empty? #=> true ``` LLM output is often Markdown; newlines and spaces affect rendering (unlike HTML where whitespace is often collapsed without impact) so we should keep whitespace chunks during streaming
Contributor
Author
|
Replaced by #636 — opened from a feature branch with a cleaner diff and improved description. |
crmne
pushed a commit
that referenced
this pull request
Feb 26, 2026
## Summary `String#blank?` drops whitespace-only chunks (newlines, spaces) during streaming. LLM output can include content where whitespace is significant for correct rendering (e.g. Markdown), so use `String#empty?` instead to only skip truly empty chunks. Replaces #537 (was opened from main by mistake).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Use
empty?instead ofblank?so whitespace-only chunks (e.g., "\n" or " ") aren’t droppedWhy
For example, LLM output is often whitespace-sensitive (think Markdown): dropping streamed newlines or spaces can change the rendered result, even if HTML would ignore them
Type of change
Scope check
Quality check
overcommit --installand all hooks passbundle exec rake vcr:record[provider_name]bundle exec rspecmodels.json,aliases.json)API changes