Skip to content

DO NOT MERGE: Testing https://github.com/kolyshkin/runc/tree/cgroups-002#9221

Closed
chuanchang wants to merge 1 commit intocri-o:mainfrom
chuanchang:test_kolyshkin_cgroups-002
Closed

DO NOT MERGE: Testing https://github.com/kolyshkin/runc/tree/cgroups-002#9221
chuanchang wants to merge 1 commit intocri-o:mainfrom
chuanchang:test_kolyshkin_cgroups-002

Conversation

@chuanchang
Copy link
Copy Markdown
Contributor

@chuanchang chuanchang commented May 26, 2025

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

@chuanchang chuanchang requested a review from mrunalp as a code owner May 26, 2025 14:46
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 26, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci Bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 26, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 26, 2025

Hi @chuanchang. Thanks for your PR.

I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci Bot requested review from QiWang19 and klihub May 26, 2025 14:46
@codecov
Copy link
Copy Markdown

codecov Bot commented May 26, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.44%. Comparing base (4abe996) to head (e233e82).
⚠️ Report is 443 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9221      +/-   ##
==========================================
- Coverage   66.50%   66.44%   -0.06%     
==========================================
  Files         198      198              
  Lines       27164    27164              
==========================================
- Hits        18065    18049      -16     
- Misses       7612     7628      +16     
  Partials     1487     1487
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kolyshkin kolyshkin mentioned this pull request May 27, 2025
Merged
@kolyshkin
Copy link
Copy Markdown
Collaborator

kolyshkin commented May 27, 2025

/approve
(for testing)

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chuanchang, kolyshkin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2025
@kolyshkin
Copy link
Copy Markdown
Collaborator

kolyshkin commented May 27, 2025

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 27, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 27, 2025 •
edited
Loading

@chuanchang: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-e2e-evented-pleg e233e82 link false /test ci-e2e-evented-pleg

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 28, 2025

A friendly reminder that this PR had no activity for 30 days.

@github-actions github-actions Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 28, 2025
@github-actions github-actions Bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 19, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 18, 2025

A friendly reminder that this PR had no activity for 30 days.

@github-actions github-actions Bot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 18, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 19, 2025

A friendly reminder that this PR had no activity for 30 days.

@github-actions github-actions Bot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 19, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 20, 2025
@openshift-merge-robot
Copy link
Copy Markdown
Contributor

openshift-merge-robot commented Sep 20, 2025

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 13, 2025

A friendly reminder that this PR had no activity for 30 days.

@github-actions github-actions Bot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 13, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 14, 2025

A friendly reminder that this PR had no activity for 30 days.

@github-actions github-actions Bot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 14, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 15, 2026

A friendly reminder that this PR had no activity for 30 days.

@github-actions github-actions Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 15, 2026
@kolyshkin
Copy link
Copy Markdown
Collaborator

kolyshkin commented Jan 15, 2026

This probably needs to be closed

@kolyshkin kolyshkin closed this Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@klihub klihub Awaiting requested review from klihub

@QiWang19 QiWang19 Awaiting requested review from QiWang19

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chuanchang @kolyshkin @openshift-merge-robot