server: create cgroupns when running on cgroup v2#3098
Merged
openshift-merge-robot merged 1 commit intocri-o:masterfrom Jan 10, 2020
Merged
server: create cgroupns when running on cgroup v2#3098openshift-merge-robot merged 1 commit intocri-o:masterfrom
openshift-merge-robot merged 1 commit intocri-o:masterfrom
Conversation
when running on a cgroup 2 host, create automatically the cgroupns. Signed-off-by: Giuseppe Scrivano <[email protected]>
openshift-ci-robot
added
the
dco-signoff: yes
openshift-ci-robot
added
approved
Contributor
|
LGTM assuming happy tests |
Codecov Report
@@ Coverage Diff @@
## master #3098 +/- ##
==========================================
- Coverage 45.78% 45.76% -0.02%
==========================================
Files 90 90
Lines 7466 7469 +3
==========================================
Hits 3418 3418
- Misses 3753 3756 +3
Partials 295 295 |
mrunalp
approved these changes
Jan 10, 2020
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, mrunalp, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when running on a cgroup 2 host, create automatically the cgroupns.
This is being discussed as part of the cgroup v2 support KEP
Signed-off-by: Giuseppe Scrivano [email protected]