Skip to content

privileged: set mounts to rw#2627

Merged
openshift-merge-robot merged 1 commit intocri-o:masterfrom
vrothberg:fix-2625
Jul 18, 2019
Merged

privileged: set mounts to rw#2627
openshift-merge-robot merged 1 commit intocri-o:masterfrom
vrothberg:fix-2625

Conversation

@vrothberg
Copy link
Copy Markdown
Member

@vrothberg vrothberg commented Jul 18, 2019 •
edited
Loading

Set all OCI mounts as privileged when running in privileged mode.

Fixes: #2625
Signed-off-by: Valentin Rothberg [email protected]

@vrothberg vrothberg requested review from mrunalp and runcom as code owners July 18, 2019 11:37
@openshift-ci-robot openshift-ci-robot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Jul 18, 2019
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 18, 2019
@vrothberg vrothberg force-pushed the fix-2625 branch 2 times, most recently from 36c2658 to 50bd5a5 Compare July 18, 2019 11:43
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 18, 2019 •
edited
Loading

Codecov Report

Merging #2627 into master will increase coverage by 0.18%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #2627      +/-   ##
==========================================
+ Coverage   53.17%   53.36%   +0.18%     
==========================================
  Files          81       81              
  Lines        6964     6992      +28     
==========================================
+ Hits         3703     3731      +28     
  Misses       2903     2903              
  Partials      358      358

giuseppe
giuseppe reviewed Jul 18, 2019
View reviewed changes
Comment thread server/container_create_linux.go Outdated
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 18, 2019
@vrothberg
privileged: set mounts to rw
d3a50d8 
Set all OCI mounts as privileged when running in privileged mode.

Fixes: cri-o#2625
Signed-off-by: Valentin Rothberg <[email protected]>
@vrothberg
Copy link
Copy Markdown
Member Author

vrothberg commented Jul 18, 2019

/test critest_rhel
/test integration_fedora

@vrothberg
Copy link
Copy Markdown
Member Author

vrothberg commented Jul 18, 2019

/test integration_fedora

4 similar comments
@vrothberg
Copy link
Copy Markdown
Member Author

vrothberg commented Jul 18, 2019

/test integration_fedora

@vrothberg
Copy link
Copy Markdown
Member Author

vrothberg commented Jul 18, 2019

/test integration_fedora

@vrothberg
Copy link
Copy Markdown
Member Author

vrothberg commented Jul 18, 2019

/test integration_fedora

@vrothberg
Copy link
Copy Markdown
Member Author

vrothberg commented Jul 18, 2019

/test integration_fedora

@vrothberg
Copy link
Copy Markdown
Member Author

vrothberg commented Jul 18, 2019

@giuseppe @rhatdan PTAL

@haircommander
Copy link
Copy Markdown
Member

haircommander commented Jul 18, 2019

/test e2e-fedora

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jul 18, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mrunalp
Copy link
Copy Markdown
Member

mrunalp commented Jul 18, 2019

/test e2e_fedora

@mrunalp
Copy link
Copy Markdown
Member

mrunalp commented Jul 18, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2019
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jul 18, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit ce94f79 into cri-o:master Jul 18, 2019
@vrothberg vrothberg deleted the fix-2625 branch July 19, 2019 06:09
@vrothberg vrothberg mentioned this pull request Jul 19, 2019
Closed
giuseppe
giuseppe reviewed Jul 19, 2019
View reviewed changes
Comment thread server/container_create_linux.go
@vrothberg
Copy link
Copy Markdown
Member Author

vrothberg commented Jul 19, 2019

Preparing backports now.

@vrothberg vrothberg mentioned this pull request Jul 25, 2019
Merged
This was referenced Nov 26, 2019
Merged
Closed
@kolyshkin kolyshkin mentioned this pull request Oct 9, 2020
Closed
@champtar champtar mentioned this pull request Apr 25, 2023
Closed
@champtar champtar mentioned this pull request Mar 3, 2025
Merged
@danwinship danwinship mentioned this pull request Sep 17, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@giuseppe giuseppe giuseppe left review comments

@mrunalp mrunalp mrunalp approved these changes

@runcom runcom Awaiting requested review from runcom

@rhatdan rhatdan Awaiting requested review from rhatdan

@sameo sameo Awaiting requested review from sameo

Assignees

@mrunalp mrunalp

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

kube-proxy pod unable to write to /sys with cri-o

6 participants

@vrothberg @haircommander @openshift-ci-robot @mrunalp @giuseppe @openshift-merge-robot