feat: add support for multiple PHP services by iamroi · Pull Request #195 · cretueusebiu/valet-windows

iamroi · 2022-03-05T16:20:40Z

Hey! Amazing work on the package <3

Currently it's missing the multiple PHP versions management and the valet use command is disabled.

This PR adds below new commands and enables valet use to switch between PHP versions.

php:add            Add PHP by specifying a path
php:install        Reinstall all PHP services from [valet php:list]
php:list           List all PHP services
php:remove         Remove PHP by specifying a path
php:uninstall      Uninstall all PHP services from [valet php:list]

use                Change the version of PHP used by valet

Examples:
valet php:add "c:\php-7.3.29"
valet php:remove "c:\php-8.1.2"
valet use 8.0.15

$ valet php:list
Listing PHP services...
+---------+---------------+------+-------------+---------+
| Version | Path          | Port | xDebug Port | Default |
+---------+---------------+------+-------------+---------+
| 8.0.15  | C:\php-8.0.15 | 9001 | 9101        |         |
| 8.1.2   | C:\php-8.1.2  | 9002 | 9102        |         |
| 7.4.27  | C:\php-7.4.27 | 9004 | 9104        |         |
| 7.3.29  | C:\php-7.3.29 | 9005 | 9105        | X       |
+---------+---------------+------+-------------+---------+

Also added a feature to enable an individual site to use a specific PHP version similar to this original Valet package PR laravel#1192

Example:
valet use "8.1.2" --site="foo"

cretueusebiu · 2022-03-07T09:16:46Z

Thanks! I'll check it latter in the week.

damsfx · 2022-05-04T23:42:03Z

@cretueusebiu any news on this eagerly awaited PR?

lekeabiodun · 2022-06-06T10:02:14Z

@cretueusebiu Any update on this PR?

muath-ye · 2022-06-09T17:16:59Z

I really awaiting this massy update which will allow me to run multiple php version for each project.
@cretueusebiu are this PR going to be merged or you are planning to use the official valet v3?

cretueusebiu · 2022-06-09T17:25:19Z

@muath-ye It's been a while since I've worked on Valet... For me it worked great so far so that's why I didn't make any updates.

Also these kind of changes require a bit of manual testing both on win 8 and 10.

I'll try to take a look this weekend at both the PR and the official Valet. 🤞

damsfx · 2022-06-15T14:13:08Z

It becomes quite urgent for me to have different versions of PHP for each project.

@iamroi What would be the best way to use your PR as a replacement?

iamroi · 2022-06-22T00:34:25Z

Hi @damsfx you can tell composer to use the forked repository. This might help - https://stackoverflow.com/questions/13498519/how-to-require-a-fork-with-composer

Please note that I still need to do thorough testing to make sure everything works as expected.

@cretueusebiu I'm hoping to add some tests this weekend.

iamroi · 2022-06-22T00:37:21Z

Hey @damsfx Please beware of the below

Currently, if you miss the double quotes from this command or any other similar command for eg. valet php:add "c:\php-7.3.29", I think it still runs but stores wrong data in the config. This needs to be resolved.

damsfx · 2022-06-22T16:39:26Z

Hi @damsfx you can tell composer to use the forked repository. This might help - https://stackoverflow.com/questions/13498519/how-to-require-a-fork-with-composer

Please note that I still need to do thorough testing to make sure everything works as expected.

@cretueusebiu I'm hoping to add some tests this weekend.

Yes, I found the solution some time ago:

{
    "require": {
         ...
        "cretueusebiu/valet-windows": "dev-master"
    },
    "repositories": [
        {
            "type": "git",
            "url": "[email protected]:iamroi/valet-windows.git"
        }
    ]
}

I have made some tests ... and suggested you a PR to add PHP version in links table letting us know which version each site is running.
iamroi#1

Too busy at the moment to resume testing, but I will try.

iamroi · 2022-06-27T00:23:41Z

+ */
+$app->command('php:add [path]', function ($path) {
+    info("Adding {$path}...");
+


@iamroi TODO check if the $path is valid before proceeding

ricky-rebo · 2022-09-22T07:36:09Z

Hi @cretueusebiu , any update on this feature?

damsfx · 2023-01-19T15:23:51Z

Hi @cretueusebiu , any update on this feature?

@cretueusebiu Bump !

meorajrul · 2023-02-02T11:26:07Z

this feature held me back to switch from laragon

Terrychang0337 · 2023-02-19T02:33:57Z

Hi there! I've install the valet version 2.5, and try to use the command valet php:add "C:\xampp\php81" , but it shows There are no commands defined in the "php" namespace. . Did I miss something?
Thanks in advance.

RohanSakhale · 2023-03-17T05:38:02Z

@cretueusebiu any possible ETA to have this PR merged, this feature is eagerly required by majority dev's

yCodeTech · 2023-04-14T22:40:31Z

Hi @damsfx you can tell composer to use the forked repository. This might help - https://stackoverflow.com/questions/13498519/how-to-require-a-fork-with-composer
Please note that I still need to do thorough testing to make sure everything works as expected.
@cretueusebiu I'm hoping to add some tests this weekend.

Yes, I found the solution some time ago:
{
    "require": {
         ...
        "cretueusebiu/valet-windows": "dev-master"
    },
    "repositories": [
        {
            "type": "git",
            "url": "[email protected]:iamroi/valet-windows.git"
        }
    ]
}

Hi @damsfx . Can you tell me where you've added this please? Is it per project basis (in project's composer.json), or in the global installation of cretueusebiu/valet-windows composer.json?

@cretueusebiu This is a very much needed requirement for developers. This pr has the backing of a multitude of people and should be merged asap. I love the valet windows port but it is muchly lacking in this php version switch mechanic.

harshitpeer · 2023-04-21T16:15:47Z

Hi @damsfx you can tell composer to use the forked repository. This might help - https://stackoverflow.com/questions/13498519/how-to-require-a-fork-with-composer
Please note that I still need to do thorough testing to make sure everything works as expected.
@cretueusebiu I'm hoping to add some tests this weekend.

Yes, I found the solution some time ago:
{
    "require": {
         ...
        "cretueusebiu/valet-windows": "dev-master"
    },
    "repositories": [
        {
            "type": "git",
            "url": "[email protected]:iamroi/valet-windows.git"
        }
    ]
}
Hi @damsfx . Can you tell me where you've added this please? Is it per project basis (in project's composer.json), or in the global installation of cretueusebiu/valet-windows composer.json?

@cretueusebiu This is a very much needed requirement for developers. This pr has the backing of a multitude of people and should be merged asap. I love the valet windows port but it is muchly lacking in this php version switch mechanic.

@yCodeTech you need to update the global composer file, usually located at C:\Users(your user)\AppData\Roaming\Composer

and then simply run composer global require cretueusebiu/valet-windows:dev-master to sync

Raja Munisamy added 8 commits March 6, 2022 01:53

feat: add support for managing multiple PHP services

c8dae50

feat: enable valet use command

21c2514

chore: fix styleci issues

5354caf

chore: fix styleci issues

804d6bc

chore: fix secure and unsecure sites individual php version switch

07ecf75

chore: fix styleci issues

ab80cc1

chore: fix styleci issues

b256c45

chore: fix styleci issues

c809382

muath-ye mentioned this pull request Jun 9, 2022

Add valet 3 #198

Open

iamroi commented Jun 27, 2022

View reviewed changes

Conversation

iamroi commented Mar 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cretueusebiu commented Mar 7, 2022

Uh oh!

damsfx commented May 4, 2022

Uh oh!

lekeabiodun commented Jun 6, 2022

Uh oh!

muath-ye commented Jun 9, 2022

Uh oh!

cretueusebiu commented Jun 9, 2022

Uh oh!

damsfx commented Jun 15, 2022

Uh oh!

iamroi commented Jun 22, 2022

Uh oh!

iamroi commented Jun 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

damsfx commented Jun 22, 2022

Uh oh!

iamroi Jun 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ricky-rebo commented Sep 22, 2022

Uh oh!

damsfx commented Jan 19, 2023

Uh oh!

meorajrul commented Feb 2, 2023

Uh oh!

Terrychang0337 commented Feb 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RohanSakhale commented Mar 17, 2023

Uh oh!

yCodeTech commented Apr 14, 2023

Uh oh!

harshitpeer commented Apr 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

iamroi commented Mar 5, 2022 •

edited

Loading

iamroi commented Jun 22, 2022 •

edited

Loading

iamroi Jun 27, 2022 •

edited

Loading

Terrychang0337 commented Feb 19, 2023 •

edited

Loading

harshitpeer commented Apr 21, 2023 •

edited

Loading