Feature/use route name hook#141
Merged
einazare merged 3 commits intocreativetimofficial:dev-masterfrom Oct 22, 2020
Merged
Conversation
…ev-master Feature: update dependencies
Contributor
|
Hello there, @mortezashojaei , Can you please provide motivation for this PR? Best, |
Author
|
Hi first of all makeBrand function needs to modify because : 1.there is no need to .map function when we don’t want render something or map an array 2.using var isn’t good pattern here its better to use let and i think sometimes wee need to use route name in other components so having a hook for this is good idea. and having hooks directory will help us adding more hooks for duplicated functionalities |
Contributor
|
Sorry, I didn't see the fact that you changed the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.