Skip to content

Feature/use route name hook#141

Merged
einazare merged 3 commits intocreativetimofficial:dev-masterfrom
mortezashojaei:feature/use-route-name-hook
Oct 22, 2020
Merged

Feature/use route name hook#141
einazare merged 3 commits intocreativetimofficial:dev-masterfrom
mortezashojaei:feature/use-route-name-hook

Conversation

@mortezashojaei
Copy link
Copy Markdown

No description provided.

@einazare
Copy link
Copy Markdown
Contributor

Hello there, @mortezashojaei ,

Can you please provide motivation for this PR?

Best,
Manu

@mortezashojaei
Copy link
Copy Markdown
Author

Hi

first of all makeBrand function needs to modify because :

1.there is no need to .map function when we don’t want render something or map an array

2.using var isn’t good pattern here its better to use let

and i think sometimes wee need to use route name in other components so having a hook for this is good idea.

and having hooks directory will help us adding more hooks for duplicated functionalities

@einazare
Copy link
Copy Markdown
Contributor

Sorry, I didn't see the fact that you changed the map to forEach, don't know why I used the map :).

@einazare einazare merged commit fa180c3 into creativetimofficial:dev-master Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants