Skip to content

Commit 3abf458

Browse files
committed
Notify about intentionally using blocking io on Darwin
1 parent 75e52f1 commit 3abf458

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

io_test.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,13 @@ func TestReadClose(t *testing.T) {
7272

7373
// Open pty and setup watchdogs for graceful and not so graceful failure modes
7474
func prepare(t *testing.T) (ptmx *os.File, done func()) {
75+
if runtime.GOOS == "darwin" {
76+
t.Log("creack/pty uses blocking i/o on darwin intentionally:")
77+
t.Log("> https://github.com/creack/pty/issues/52")
78+
t.Log("> https://github.com/creack/pty/pull/53")
79+
t.Log("> https://github.com/golang/go/issues/22099")
80+
t.SkipNow()
81+
}
7582

7683
// Due to data race potential in (*os.File).Fd()
7784
// we should never run these two tests in parallel

0 commit comments

Comments
 (0)