remove SPC_CMD_VAR_PHP_CONFIGURE_CFLAGS, use eu-strip #966
Conversation
# Conflicts: # config/lib.json # src/SPC/builder/unix/UnixBuilderBase.php
henderkes
changed the title
| if ($version = getenv('FRANKENPHP_VERSION')) { | ||
| return $version; | ||
| } | ||
| $frankenphpSourceDir = getenv('FRANKENPHP_SOURCE_PATH') ?: SOURCE_PATH . '/frankenphp'; | ||
| $goModPath = $frankenphpSourceDir . '/caddy/go.mod'; |
There was a problem hiding this comment.
Is there any point of these new introduced env vars? In which scenarios would they be used?
There was a problem hiding this comment.
essentially for frankenphp developers, so they can use the current frankenphp source directory instead of having spc download it
There was a problem hiding this comment.
I would prefer not to use the FRANKENPHP_VERSION variable, but frankenphp source currently expects it to be defined by CGO_CFLAGS. It's not optimal :/
There was a problem hiding this comment.
essentially for frankenphp developers, so they can use the current frankenphp source directory instead of having spc download it
We currently have a source type local, but there's no option to specify a custom local. I'll think about how to handle that tomorrow.
There was a problem hiding this comment.
I'm currently refactoring the artifact part of version 3.0, and I don't really want to add more new APIs/options to version 2.x, so this workaround is acceptable for me, since there's currently no way to customize the local source.
There was a problem hiding this comment.
Yeah I don't mind the FRANKENPHP_SOURCE_PATH, that part seems alright to me. It's the FRANKENPHP_VERSION that I'm not a fan of, but I have no idea how to mark builds as development builds rather than stable releases otherwise.
2 participants
What does this PR do?
targets no-strip branch!
Checklist before merging
*.phpor*.json, run them locally to ensure your changes are valid:composer cs-fixcomposer analysecomposer testbin/spc dev:sort-configsrc/globals/test-extensions.php.extension testortest extensionsto trigger full test suite.