Use cmake to build librdkafka, add helper function for SPCConfigUtil #955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed deduplication of pkg-config libraries.
Owner
|
Looks like we don't need to patch or pass redundant variables to librdkafka if we use cmake build. I'll push cmake version later. And btw I added some helper function in SPCConfigUtil to make it more convenient to use. |
crazywhalecc
approved these changes
Nov 4, 2025
Owner
|
Feel free to merge if it is good. |
crazywhalecc
changed the title
henderkes
commented
Nov 4, 2025
| protected function build(): void | ||
| { | ||
| UnixAutoconfExecutor::create($this) | ||
| ->appendEnv(['CFLAGS' => '-Wno-int-conversion -Wno-unused-but-set-variable -Wno-unused-variable']) |
Collaborator
Author
There was a problem hiding this comment.
please test with zig and clang on linux, both failed witho -Wno-int-conversion last time
Owner
There was a problem hiding this comment.
Just tested with native-native-musl and native-native-gnu.2.17 target. It works well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
closes #954