Skip to content

fix postgresql libraries when --with-suggested-libs is false #952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
henderkes merged 2 commits into from
Oct 31, 2025
Merged

fix postgresql libraries when --with-suggested-libs is false #952

henderkes merged 2 commits into from
Oct 31, 2025

Conversation

@henderkes
Copy link
Collaborator

@henderkes henderkes commented Oct 29, 2025

What does this PR do?

fix php/frankenphp#1937

Checklist before merging

If your PR involves the changes mentioned below and completed the action, please tick the corresponding option.
If a modification is not involved, please skip it directly.

  • If you modified *.php or *.json, run them locally to ensure your changes are valid:
    • composer cs-fix
    • composer analyse
    • composer test
    • bin/spc dev:sort-config
  • If it's an extension or dependency update, please ensure the following:
    • Add your test combination to src/globals/test-extensions.php.
    • If adding new or fixing bugs, add commit message containing extension test or test extensions to trigger full test suite.

@henderkes henderkes marked this pull request as ready for review October 29, 2025 17:56
crazywhalecc
crazywhalecc reviewed Oct 30, 2025
View reviewed changes
crazywhalecc
crazywhalecc requested changes Oct 31, 2025
View reviewed changes
Copy link
Owner

@crazywhalecc crazywhalecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to add these functions to achieve this, just change postgresql.php file, add true to getDependencies() function.

$libs = array_map(fn ($x) => $x->getName(), $this->getDependencies(true));

@henderkes
Copy link
Collaborator Author

henderkes commented Oct 31, 2025

We don't need to add these functions to achieve this, just change postgresql.php file, add true to getDependencies() function.

$libs = array_map(fn ($x) => $x->getName(), $this->getDependencies(true));

Good catch. Is there even a point in keeping a non-recursive version of it?

@crazywhalecc
Copy link
Owner

crazywhalecc commented Oct 31, 2025 •
edited
Loading

Good catch. Is there even a point in keeping a non-recursive version of it?

For displaying current-level dependencies to check optional libraries status. It's usually used with my local dependency debugging for some cases. There's no need to remove this.

@henderkes henderkes merged commit ae15d6c into main Oct 31, 2025
39 of 40 checks passed
@henderkes henderkes deleted the fix/pgsql-libs branch October 31, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crazywhalecc crazywhalecc crazywhalecc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

static binary CI fails postgresql build

2 participants

@henderkes @crazywhalecc