Fix libevent build, use newer cmake options #945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazywhalecc
commented
Oct 24, 2025
henderkes
approved these changes
Oct 24, 2025
Collaborator
henderkes
left a comment
henderkes
left a comment
There was a problem hiding this comment.
weird, libevent compiles perfectly fine for me
where does it fail to compile with the old option?
Owner
Author
No idea. This is not related to libevent itself, maybe using CMake 3.x works well, but I have upgraded to cmake 4 already. The safest way at the moment is to use this new version's var and add the |
Collaborator
|
I've been on CMake 4 since the week it came out. I remember creating a rather large PR back then that removed deprecated options everywhere, before we had the UnixCmakeConfigurator class. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix https://github.com/static-php/static-php-cli-hosted/actions/runs/18767020353/job/53543930166
Checklist before merging
*.phpor*.json, run them locally to ensure your changes are valid:composer cs-fixcomposer analysecomposer testbin/spc dev:sort-configsrc/globals/test-extensions.php.extension testortest extensionsto trigger full test suite.