Skip to content

Conversation

@crazywhalecc
Copy link
Owner

@crazywhalecc crazywhalecc commented Oct 20, 2025

What does this PR do?

  • Add pie download type support
  • Use strip when extracting with unzip and 7z.exe (This may impact all windows related things, will fix them later)
  • Strict ConfigValidator, fix potential wrong configs
  • Update composer dependencies

The pie download is not available for many pecl extensions yet, it is not appropriate to replace all extensions downloaded from pecl.php.net with pie now.

Checklist before merging

If your PR involves the changes mentioned below and completed the action, please tick the corresponding option.
If a modification is not involved, please skip it directly.

  • If you modified *.php or *.json, run them locally to ensure your changes are valid:
    • composer cs-fix
    • composer analyse
    • composer test
    • bin/spc dev:sort-config
  • If it's an extension or dependency update, please ensure the following:
    • Add your test combination to src/globals/test-extensions.php.
    • If adding new or fixing bugs, add commit message containing extension test or test extensions to trigger full test suite.

@henderkes
Copy link
Collaborator

Looks good so far, but I'll need to check out the lib changes on a pc later.

@crazywhalecc
Copy link
Owner Author

crazywhalecc commented Oct 20, 2025

Windows pkgs using zip all failed as expected. The dir stripping is not good for everything, some zip needs wrapping in previous dir.

@crazywhalecc crazywhalecc changed the base branch from main to sapi/cgi-win October 21, 2025 07:44
@crazywhalecc crazywhalecc merged commit b519291 into sapi/cgi-win Oct 21, 2025
1 check passed
@crazywhalecc crazywhalecc deleted the feat/pie branch October 21, 2025 08:20
@crazywhalecc crazywhalecc restored the feat/pie branch October 21, 2025 09:01
@crazywhalecc crazywhalecc deleted the feat/pie branch October 21, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants