Fix zig -isystem overriding #896
Conversation
crazywhalecc
left a comment
crazywhalecc
left a comment
There was a problem hiding this comment.
I noticed the other packages would have the same issue here, and these are working with using extract-files to solve this. So far so good for me, but for unification it looks better to refactor them all in 3.0.
|
|
||
| SCRIPT_DIR="$(dirname "${BASH_SOURCE[0]}")" | ||
| BUILDROOT_ABS="$(realpath "$SCRIPT_DIR/../../buildroot/include" 2>/dev/null || true)" | ||
| BUILDROOT_ABS="$(realpath "$SCRIPT_DIR/../../../buildroot/include" 2>/dev/null || true)" |
There was a problem hiding this comment.
How about using BUILD_INCLUDE_PATH variable? We call zig-cc.sh inside SPC can use it.
There was a problem hiding this comment.
That would make it a problem with docker. or when the env variable was set at oen time but then unset at another We need to use relative paths unfortunately.
There was a problem hiding this comment.
// ConsoleApplication.php
require_once ROOT_DIR . '/src/globals/internal-env.php';
// internal-env.php
putenv('BUILD_INCLUDE_PATH=' . BUILD_INCLUDE_PATH);It shouldn't have issue with docker, it's pre-defined in SPC startup, and it said in env.ini: these variables cannot be changed anywhere.
There was a problem hiding this comment.
Oh, you mean like passing the environment variable into the script. I thought you meant hardcoding it at the time of running install-pkg. That makes sense.
2 participants
What does this PR do?
and rename folders from pkgroot/$arch-$os/zig-$arch-$os to pkgroot/$arch-$os/zig