Skip to content

Conversation

@henderkes
Copy link
Collaborator

What does this PR do?

Checklist before merging

If your PR involves the changes mentioned below and completed the action, please tick the corresponding option.
If a modification is not involved, please skip it directly.

  • If you modified *.php or *.json, run them locally to ensure your changes are valid:
    • composer cs-fix
    • composer analyse
    • composer test
    • bin/spc dev:sort-config
  • If it's an extension or dependency update, please ensure the following:
    • Add your test combination to src/globals/test-extensions.php.
    • If adding new or fixing bugs, add commit message containing extension test or test extensions to trigger full test suite.

@henderkes
Copy link
Collaborator Author

I'm not sure why, but this step is failing nearly every time on at least one runner.

@henderkes
Copy link
Collaborator Author

No idea what happened in the CI here, php cs fixer hallucinated?

@crazywhalecc
Copy link
Owner

Sigh. This is why I like to keep downloading and building completely separate. It's also one of the things I don't like about Go: it always requires a network connection to GitHub.

I think it's time to change this approach to getting releases. Issues with accessing the GitHub API are the most common download issues we encounter.

@crazywhalecc
Copy link
Owner

No idea what happened in the CI here, php cs fixer hallucinated?

Nope. The cs fixer just has another minor update that introduced new rules. I've updated in another branch.

@henderkes
Copy link
Collaborator Author

Sigh. This is why I like to keep downloading and building completely separate. It's also one of the things I don't like about Go: it always requires a network connection to GitHub.

Technically we can pull everything in the download phase and use go build manually. It's just rather annoying to do - xcaddy doesn't fail with the download too often (not once in CI yet).

We can add frankenphp as a downloader source and store the version, though. What do you think?

@crazywhalecc
Copy link
Owner

We can add frankenphp as a downloader source and store the version, though. What do you think?

Initially I want this way, but it will be more redundant downloads for building non-frankenphp sapis. And I remember we discussed it before, the xcaddy seems no way to download without building.

Only for this PR related thing: I think we could fetch frankenphp version after go-xcaddy package installed.

@henderkes henderkes changed the title keep retrying more switch getting frankenphp version to go mod (bypass rate limits) Sep 4, 2025
@henderkes henderkes merged commit 2eeba33 into main Sep 4, 2025
5 of 6 checks passed
@henderkes henderkes deleted the dumb_github branch September 4, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants