Skip to content

Conversation

@crazywhalecc
Copy link
Owner

What does this PR do?

Previously we use --prefix= to build unixodbc, which will search odbc.ini in $prefix/etc/odbc.ini, that is, /etc/odbc.ini.

For different linux distros and different ways of installing the msodbcsql driver, we may need to set different values ​​or variables, but here I am mainly trying to fix the default installation and use of macOS.

Checklist before merging

If your PR involves the changes mentioned below and completed the action, please tick the corresponding option.
If a modification is not involved, please skip it directly.

  • If you modified *.php or *.json, run them locally to ensure your changes are valid:
    • composer cs-fix
    • composer analyse
    • composer test
    • bin/spc dev:sort-config
  • If it's an extension or dependency update, please ensure the following:
    • Add your test combination to src/globals/test-extensions.php.
    • If adding new or fixing bugs, add commit message containing extension test or test extensions to trigger full test suite.

@henderkes
Copy link
Collaborator

Why do x86_64 and aarch64 have different paths?

@crazywhalecc
Copy link
Owner Author

crazywhalecc commented Sep 1, 2025

The Apple Silicon mac's homebrew is under /opt/homebrew, and intel mac is under /usr/local. And the mssql driver is using homebrew tap to install it.

Copy link
Collaborator

@henderkes henderkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@crazywhalecc crazywhalecc merged commit a77e49c into main Sep 1, 2025
9 of 10 checks passed
@crazywhalecc crazywhalecc deleted the fix/unixodbc-search branch September 1, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants